Skip to content

Interpreter unit tests are failing on AppVeyor #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DonJayamanne opened this issue May 11, 2018 · 0 comments · Fixed by #1697
Closed

Interpreter unit tests are failing on AppVeyor #1660

DonJayamanne opened this issue May 11, 2018 · 0 comments · Fixed by #1697
Assignees
@DonJayamanne
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
May 2018

Comments

@DonJayamanne
Copy link 

  1) Interpreters from Windows Registry
       Must default names for PythonCore and exe:
     AssertionError: Incorrect version
      at Object.<anonymous> (C:\projects\vscode-python-v3vd6\src\test\interpreters\windowsRegistryService.test.ts:88:20)
      at Generator.next (<anonymous>)
      at fulfilled (C:\projects\vscode-python-v3vd6\out\test\interpreters\windowsRegistryService.test.js:4:58)
      at <anonymous>
  2) Interpreters from Windows Registry
       Must return a single entry and when registry contains only the InstallPath:
     AssertionError: Incorrect version
      at Object.<anonymous> (C:\projects\vscode-python-v3vd6\src\test\interpreters\windowsRegistryService.test.ts:123:20)
      at Generator.next (<anonymous>)
      at fulfilled (C:\projects\vscode-python-v3vd6\out\test\interpreters\windowsRegistryService.test.js:4:58)
      at <anonymous>
  3) Interpreters from Windows Registry
       Must return multiple entries:
     AssertionError: Incorrect version
      at Object.<anonymous> (C:\projects\vscode-python-v3vd6\src\test\interpreters\windowsRegistryService.test.ts:165:20)
      at Generator.next (<anonymous>)
      at fulfilled (C:\projects\vscode-python-v3vd6\out\test\interpreters\windowsRegistryService.test.js:4:58)
      at <anonymous>
  4) Interpreters from Windows Registry
       Must return multiple entries excluding the invalid registry items and duplicate paths:
     AssertionError: Incorrect version
      at Object.<anonymous> (C:\projects\vscode-python-v3vd6\src\test\interpreters\windowsRegistryService.test.ts:224:20)
      at Generator.next (<anonymous>)
      at fulfilled (C:\projects\vscode-python-v3vd6\out\test\interpreters\windowsRegistryService.test.js:4:58)
      at <anonymous>
  5) Interpreters from Windows Registry
       Must return multiple entries excluding the invalid registry items and nonexistent paths:
     AssertionError: 1. Incorrect version
      at Object.<anonymous> (C:\projects\vscode-python-v3vd6\src\test\interpreters\windowsRegistryService.test.ts:284:20)
      at Generator.next (<anonymous>)
      at fulfilled (C:\projects\vscode-python-v3vd6\out\test\interpreters\windowsRegistryService.test.js:4:58)
      at <anonymous>
@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels May 11, 2018
@DonJayamanne DonJayamanne added this to the May 2018 milestone May 11, 2018
@DonJayamanne DonJayamanne self-assigned this May 11, 2018
@DonJayamanne DonJayamanne mentioned this issue May 16, 2018
Merged
2 tasks
DonJayamanne added a commit that referenced this issue May 21, 2018
@DonJayamanne
Fix getting display name and version when using windows registry (#1697)
35fe3c0 
* Fixes #1660
* Fixes #1703
* 🐛 fix getting display name and version when using windows registry
* Git hook for tests
* 📝 add news entry
* Some more unit tests\
* Mock VS Code only inside the test runner
* Singleton mocks for vscode namespcaes
* Fix test
@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
May 2018
Development

Successfully merging a pull request may close this issue.

Fix getting display name and version when using windows registry DonJayamanne/pythonVSCode
1 participant
@DonJayamanne