Discovery runs conda info command multiple times during startup when large number of conda interpreters are present

[wubdub]

VS Code version

1.63.0

Extension version

v2021.12.1559732655

OS type

macOS

OS version

11.4

Python distribution

Anaconda

Python version

3.8.5

Language server

Default

Expected behaviour

I would expect the extension to just use the already selected Python interpreter on the left and provide indexer features (like the ability to click through functions) on startup.

Actual behaviour

The "Discovering Python Interpreters" dialog spins forever. If I go to "Output" and then select "Python" on the right drop down, the issue is the extension is looping through hundreds of python versions available on the cluster I am ssh'ing into.

For example, I see a constant output of the format, for everyone of hundreds of conda envs. I would just like to skip this discovering step and use the one I already selected.

> /home/XXX/.conda/envs/1e59305f3-855/bin/python ~/.vscode-server/extensions/ms-python.python-2021.12.1559732655/pythonFiles/interpreterInfo.py
> conda info --json

Steps to reproduce

Have many python versions available in your conda env.

Logs

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[karrtikr]

provide indexer features (like the ability to click through functions) on startup.

Is Discovery Interpreters somehow hindering this or your work?

[brettcannon]

Was the environment previously selected for the workspace or was the terminal you launched VS Code from already activated? Or did you open a workspace with no environment selected and then you chose it (i.e. some form of discovery would have been required to find the environment regardless)?

[wubdub]

Is Discovery Interpreters somehow hindering this or your work?

Yes, during this time that "Discovering Python Interpreters" message is present the indexer does not work so I can't click on variables, click to go to function definitions, etc.

@brettcannon, I set the "Default Interpreter Path" through this setting:

To summarize, if "Default Interpreter Path" is set, I would expect "Discovering Python Interpreters" not to have run, which would then allow features related to the indexer to work instantly

[karrtikr]

Yes, during this time that "Discovering Python Interpreters" message is present the indexer does not work so I can't click on variables, click to go to function definitions, etc.

I see, can you provide me the logs as mentioned in the issue template during the message is present? I'm interested in the commands extension runs which particularly slows things down for you.

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

XXX

Also, how long does 'conda info --json' command takes when run in terminal?

[wubdub]

Thanks @karrtikr!

log.txt attached, it looks like it fails to do something in the beginning and then starts stepping through every single conda environment in /ZZZ/shared/conda-envs/

The conda info call on the command line is very fast

$ time conda info --json 

real	0m6.149s
user	0m0.258s
sys	0m0.109s

[ghost]

Same problem here :(

[karrtikr]

@wubdub Please try the following VSIX https://github.com/microsoft/vscode-python/suites/4975845256/artifacts/145186523 and let me know if it helps: Use Extension: Install from VSIX... command to install the VSIX.

[wubdub]

@karrtikr thanks! I get a "Failed to generate URL to download artifact" message, perhaps it has expired?

[brettcannon]

@wubdub yep, we only keep GitHub Actions artifacts around for a week.

@karrtikr was that to a build from a PR or latest insiders?

[karrtikr]

It was a build off this PR #18309, will rebuild and post the new artifact soon.

[karrtikr]

@wubdub Here: https://github.com/microsoft/vscode-python/suites/5100759928/artifacts/152543360

[wubdub]

@karrtikr it seems a bit faster now thanks, still takes about 10 mins to load each time I start VSCode, not sure if there is any other low hanging fruit. Attaching log2.txt

[karrtikr]

I'm not sure why it would take 10 mins given your log, it seems conda info --json is run repeatedly, can you add python.logging.level to debug in User settings, reload window and provide me the logs again. Use the following VSIX: https://github.com/microsoft/vscode-python/suites/5101823480/artifacts/152602533

[karrtikr]

Also, try the following VSIX where we do not trigger discovery at all: https://github.com/microsoft/vscode-python/suites/5101652551/artifacts/152593035

[karrtikr]

Ping @wubdub

[karrtikr]

Also see #18647 for the feature request you asked for.

[wubdub]

Ping @wubdub

Sorry for the delay, attached!
debug.txt

Also, within those 5 minutes, are you still blocked and cannot use other extension features?

Yes I cannot click through functions, etc. during this time

[karrtikr]

Thanks and here is the final VSIX I have for you: https://github.com/microsoft/vscode-python/suites/5609518918/artifacts/182361458

Yes I cannot click through functions, etc. during this time

Looking at the logs I noticed that the language server (Pylance) responsible for providing these features was not started until discovery was finished (created #18671). So in the VSIX above I ensure Pylance is started first, and discovery is triggered afterwards.

Let me know how long does it take here to unblock you for using the above features. Also please provide the logs.

[wubdub]

Let me know how long does it take here to unblock you for using the above features. Also please provide the logs.

Awesome!! The Pylance features are now nearly instantly available, works great!
debug.txt

[karrtikr]

Fantastic 🥳 thanks for your help. We'll fix it soon with #18671, I'll fix the bug discovered here #18200 (comment) with this issue.

[kosarkazemi]

Hello,
I am having this issue.
What should I update?
The page: https://github.com/microsoft/vscode-python/suites/5100759928/artifacts/152543360 is out of access now.

[karrtikr]

The fix is out in the latest stable release, so simply updating to the latest version of VSCode and extension should ideally fix it.

[wubdub]

@karrtikr I am actually running v2022.4.1 but the "Discovering Python Interpreters" continues to spin for a long time, printing out <various environment path>/bin/python ~/.vscode-server/extensions/ms-python.python-2022.4.1/pythonFiles/get_output_via_markers.py ~/.vscode-server/extensions/ms-python.python-2022.4.1/pythonFiles/interpreterInfo.py - perhaps this is a new issue I should file a ticket for?

[karrtikr]

This only fixes the issue that conda info command is only run once during startup. So discovery may still take longer and we may run interpreterInfo.py scripts but that is to be expected. Just make sure the same command isn't run twice.

Thank you, just ran it, seemed to take about 5+ mins to load still

Stable VSIX should bring you to this state you mentioned above.

The fact that language server isn't started will be fixed by #18671.