forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
area-internalLabel for non-user facing issuesLabel for non-user facing issuesdebtCovers everything internal: CI, testing, refactoring of the codebase, etc.Covers everything internal: CI, testing, refactoring of the codebase, etc.good first issueneeds PRReady to be worked onReady to be worked on
Description
There's no needs
clause on coverage in PR CI, which means if the tests are definitely going to fail then they will fail twice: once for the normal test run and then again when run under coverage. Either coverage should be the way to run those tests so they aren't run twice or coverage should probably not run if the test suite failed.
Metadata
Metadata
Assignees
Labels
area-internalLabel for non-user facing issuesLabel for non-user facing issuesdebtCovers everything internal: CI, testing, refactoring of the codebase, etc.Covers everything internal: CI, testing, refactoring of the codebase, etc.good first issueneeds PRReady to be worked onReady to be worked on