forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugimportantIssue identified as high-priorityIssue identified as high-priority
Description
DebuggerBanner won't open for the randomly selected users it is intended for, as it isn't set up for DI.
Environment data
- VS Code version: 1.28.0-insider
- Extension version (available under the Extensions sidebar): 2018.0
- OS and version: Ubuntu 18.04
- Python version (& distribution if applicable, e.g. Anaconda): 3.7
- Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
- Relevant/affected Python packages and their versions: n/a
Actual behavior
Users are not ever given the opportunity to provide feedback on the current debugging experience.
Expected behavior
Randomly selected users are given a popup that will direct them to a user survey (which they can dismiss if they aren't interested).
Steps to reproduce:
- Force becoming selected as a debugger feedback user.
- Debug the extension.
- In the debuggee, open the developer tools window and debug some code (can be super simple).
- End debugging session.
Logs
Output from Console
under the Developer Tools
panel (toggle Developer Tools on under Help
)
/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:285 [Extension Host] Python Extension: Error in debugger Banner Error: Missing required @injectable annotation in: Random.
at getTargets (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/reflection_utils.js:20:15)
at Object.getDependencies (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/reflection_utils.js:11:19)
at /home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/planner.js:106:51
at Array.forEach (<anonymous>)
at _createSubRequests (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/planner.js:94:20)
at Object.plan (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/planner.js:129:9)
at Container._planAndResolve (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/container/container.js:316:37)
at Container._get (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/container/container.js:309:44)
at Container.get (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/container/container.js:228:21)
at ServiceContainer.get (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/ioc/container.js:28:89)
at DebuggerBanner.<anonymous> (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:126:55)
at Generator.next (<anonymous>)
at __awaiter (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:18:71)
at new Promise (<anonymous>)
at __awaiter (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:14:12)
at DebuggerBanner.isUserSelected (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:117:16)
at DebuggerBanner.<anonymous> (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:79:25)
at Generator.next (<anonymous>)
at __awaiter (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:18:71)
at new Promise (<anonymous>)
at __awaiter (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:14:12)
at DebuggerBanner.shouldShow (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:72:16)
at DebuggerBanner.<anonymous> (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:192:37)
at Generator.next (<anonymous>)
at fulfilled (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:15:58)
at <anonymous> (at Logger.logError (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/common/logger.js:15:21))
t.log @ /usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:285
/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:2348 Formatter black is not installed. Install?
t.onDidNotificationChange @ /usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:2348
/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:285 [Extension Host] Python Extension: Error in debugger Banner Error: Missing required @injectable annotation in: Random.
at getTargets (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/reflection_utils.js:20:15)
at Object.getDependencies (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/reflection_utils.js:11:19)
at /home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/planner.js:106:51
at Array.forEach (<anonymous>)
at _createSubRequests (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/planner.js:94:20)
at Object.plan (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/planner.js:129:9)
at Container._planAndResolve (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/container/container.js:316:37)
at Container._get (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/container/container.js:309:44)
at Container.get (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/container/container.js:228:21)
at ServiceContainer.get (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/ioc/container.js:28:89)
at DebuggerBanner.<anonymous> (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:126:55)
at Generator.next (<anonymous>)
at __awaiter (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:18:71)
at new Promise (<anonymous>)
at __awaiter (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:14:12)
at DebuggerBanner.isUserSelected (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:117:16)
at DebuggerBanner.<anonymous> (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:79:25)
at Generator.next (<anonymous>)
at __awaiter (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:18:71)
at new Promise (<anonymous>)
at __awaiter (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:14:12)
at DebuggerBanner.shouldShow (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:72:16)
at DebuggerBanner.<anonymous> (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:192:37)
at Generator.next (<anonymous>)
at fulfilled (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:15:58)
at <anonymous> (at Logger.logError (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/common/logger.js:15:21))
t.log @ /usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:285
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugimportantIssue identified as high-priorityIssue identified as high-priority