Skip to content

Remove obsolete debug adapter code (when ready) #7136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
8 tasks done
kimadeline opened this issue Aug 28, 2019 · 0 comments
Closed
8 tasks done

Remove obsolete debug adapter code (when ready) #7136

kimadeline opened this issue Aug 28, 2019 · 0 comments
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@kimadeline
Copy link

kimadeline commented Aug 28, 2019 •
edited by luabud
Loading

For #6017

  • Delete everything under src/client/debugger/debugAdapter : see Remove TS debugAdapter #11755
  • Delete installOldPtvsd gulp task and refactor the installPythonRequirements gulp task (it won't be a series of tasks anymore)
  • Delete CI steps & gulp task installing ptvsd
  • Remove packaging, pyparsing and six from requirements.txt
  • Remove DebugAdapterNewPtvsd and DebugAdapterDescriptorFactory experiments
    - [ ] Remove pythonFiles/debug_adapter and clean up pythonFiles/tests/__main__.py
    Edit: The tests under pythonFiles/debug_adapter test the wheels installer for debugpy. We should keep it.
  • Remove packaging from test-requirements.txt
  • Remove legacy code in buildApi() : see Remove APIs related to ptvsd paths #11757
    - [ ] Remove pin of the Node version in the GitHub Action CI workflow (Pin the version of Node used in GHA  #10410 (comment))
    - [ ] Remove pin of the Node version in the AzDO workflows (NodeVersion in globals.yml and all the places using it)
    Edit: We have decided to pin node version for consistency across all platforms.
  • Remove all uses of ChildProcessLaunchData, isChildProcessLaunchData, and ChildProcessLaunched
@kimadeline kimadeline added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Aug 28, 2019
@DonJayamanne DonJayamanne mentioned this issue Aug 28, 2019
Closed
3 tasks
@kimadeline kimadeline changed the title Remove obsolete code once everybody is on the new debug adapter Remove obsolete debug adapter code (when ready) Aug 28, 2019
@kimadeline kimadeline mentioned this issue Sep 24, 2019
Merged
10 tasks
@kimadeline kimadeline mentioned this issue Mar 4, 2020
Merged
10 tasks
@luabud luabud mentioned this issue May 7, 2020
Closed
This was referenced May 11, 2020
Merged
Merged
Merged
@karthiknadig karthiknadig mentioned this issue May 26, 2020
Merged
@luabud luabud closed this as completed Jun 10, 2020
@ghost ghost removed the needs PR label Jun 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luabud @kimadeline