Skip to content

Pin the version of Node used in GHA #10410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 4, 2020
Merged

Pin the version of Node used in GHA #10410

merged 12 commits into from
Mar 4, 2020

Conversation

kimadeline
Copy link

For #9968

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@kimadeline kimadeline added the no-changelog No news entry required label Mar 3, 2020
@codecov-io
Copy link

codecov-io commented Mar 3, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@0a9392f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10410   +/-   ##
=========================================
  Coverage          ?   60.93%           
=========================================
  Files             ?      571           
  Lines             ?    30808           
  Branches          ?     4386           
=========================================
  Hits              ?    18773           
  Misses            ?    11080           
  Partials          ?      955

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a9392f...f8a6cd0. Read the comment docs.

@kimadeline kimadeline marked this pull request as ready for review March 3, 2020 16:40
@ericsnowcurrently ericsnowcurrently requested review from ericsnowcurrently and removed request for brettcannon and karrtikr March 3, 2020 17:14
ericsnowcurrently
ericsnowcurrently approved these changes Mar 3, 2020
View reviewed changes
Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimadeline kimadeline mentioned this pull request Mar 4, 2020
Closed
8 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kimadeline kimadeline merged commit 888ff0f into microsoft:master Mar 4, 2020
@kimadeline kimadeline deleted the gha-py27-debugger branch March 4, 2020 09:36
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@karrtikr karrtikr karrtikr approved these changes

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kimadeline @codecov-io @brettcannon @ericsnowcurrently @karrtikr