Skip to content

Pin the version of Node used in GHA #10410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 4, 2020
Merged

Pin the version of Node used in GHA #10410

Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fcc94e6
Run debugger tests with python 3.8
kimadeline Mar 3, 2020
f704ab5
Comment saved line
kimadeline Mar 3, 2020
e9c469f
Try with python 3.7
kimadeline Mar 3, 2020
e1c5e2d
Which version of node is this
kimadeline Mar 3, 2020
cfb2c3f
Use node 12.4.0
kimadeline Mar 3, 2020
875b15d
Try another Node version
kimadeline Mar 3, 2020
db6f1f7
Try Node 12.14.1
kimadeline Mar 3, 2020
93d3ffe
Add comment, test node 16.0
kimadeline Mar 3, 2020
a75360e
Try Node 12.15.0
kimadeline Mar 3, 2020
658fb11
Found last working Node version, uncomment tests
kimadeline Mar 3, 2020
f8a6cd0
Guess who's blind
kimadeline Mar 3, 2020
b913bc0
Add link to the GH issue tracking TS DA cleanup
kimadeline Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,11 @@ jobs:
# Run the tests on the oldest and most recent versions of Python.
python: [2.7, 3.8]
test-suite: [ts-unit, python-unit, venv, single-workspace, multi-workspace, debugger, functional]
env:
# Something in Node 12.16.0 breaks the TS debug adapter, and ubuntu-latest bundles Node 12.16.1.
# We can remove this when we switch over to the python-based DA.
# See https://github.com/microsoft/ptvsd/issues/2068
NODE_VERSION: 12.15.0
steps:
- name: Checkout
uses: actions/checkout@v2
Expand Down Expand Up @@ -222,6 +227,11 @@ jobs:
with:
python-version: ${{matrix.python}}

- name: Use Node ${{env.NODE_VERSION}}
uses: actions/setup-node@v1
with:
node-version: ${{env.NODE_VERSION}}

- name: curl PyPI to get debugpy versions
run: curl --output debugpy.json https://pypi.org/pypi/debugpy/json

Expand Down