Skip to content

Fix GitHub Action CI workflow tests with Python 3.8 and 2.7 #9968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kimadeline opened this issue Feb 6, 2020 · 6 comments
Closed

Fix GitHub Action CI workflow tests with Python 3.8 and 2.7 #9968

kimadeline opened this issue Feb 6, 2020 · 6 comments
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@kimadeline
Copy link

The CI workflow runs the test suites against Python 2.7 and 3.8, which are not the versions used in the CI pipeline in Azure Pipelines (3.6 and 3.7).

Python tests are failing when run on 3.8, but passing on 3.7, with failures seemingly related to pytest.

Todo:

  • Use pytest 4.6.9 for our Python tests (Run Python and IPython unit tests step)
  • Fix other Python 3.8 test failures that may arise
  • Double-check that we didn't break tests, fix them otherwise

Note: Since the changes needed are pipeline-independent we might be able to close #8298 after this.

@kimadeline kimadeline added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Feb 6, 2020
@kimadeline kimadeline self-assigned this Feb 24, 2020
@kimadeline
Copy link
Author

#10276 fixed #8298, now see if we need to make additional changes for this issue (we shouldn't need to).

@kimadeline
Copy link
Author

kimadeline commented Feb 28, 2020

Seems like there's an issue when running the debugger tests on Python 2.7 (something we don't do on AzDO): https://github.com/microsoft/vscode-python/runs/472170446?check_suite_focus=true

Unhandled error. ({
  seq: 0,
  type: 'event',
  event: 'error',
  body: 'Debugger Error: The number of constructor arguments ' +
    'in the derived class ProtocolParser must be >= than ' +
    'the number of constructor arguments of its base ' +
    'class.'
}): Error [ERR_UNHANDLED_ERROR]: Unhandled error. ({
  seq: 0,
  type: 'event',
  event: 'error',
  body: 'Debugger Error: The number of constructor arguments ' +
    'in the derived class ProtocolParser must be >= than ' +
    'the number of constructor arguments of its base ' +
    'class.'
})

  at DebugClient.emit (events.js:189:17)
    at DebugClient.dispatch (/home/runner/work/vscode-python/vscode-python/node_modules/vscode-debugadapter-testsupport/src/protocolClient.ts:138:9)
    at DebugClient.handleData (/home/runner/work/vscode-python/vscode-python/node_modules/vscode-debugadapter-testsupport/src/protocolClient.ts:109:12)
    at Socket.<anonymous> (/home/runner/work/vscode-python/vscode-python/node_modules/vscode-debugadapter-testsupport/src/protocolClient.ts:31:9)
    at Socket.emit (events.js:200:13)
    at addChunk (_stream_readable.js:294:12)
    at readableAddChunk (_stream_readable.js:275:11)
    at Socket.Readable.push (_stream_readable.js:210:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:166:17)

    1) Ensure messages are not received after disposing the parser

Edit: Fixed with PR #10410

@rchiodo
Copy link

rchiodo commented Apr 11, 2020

@kimadeline will this bug fix the 3.8 failures on the CI system?
https://dev.azure.com/ms/vscode-python/_build/results?buildId=73356&view=ms.vss-test-web.build-test-results-tab
Doesn't seem like it but I wasn't sure. The failures I'm seeing are in unit tests for windows 3.8. I believe Don just added the ipywidget failures, but I've been seeing the terminal and interpreter failures before that.

@kimadeline
Copy link
Author

The 3.8 unit tests (Ubuntu and Windows) were passing in GitHub Actions when this issue was created, so this is new. We should probably verify these test suites again though.

@kimadeline kimadeline removed their assignment May 5, 2020
@kimadeline
Copy link
Author

Stale issue, closing 🥖

@ghost ghost removed the needs PR label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

3 participants