-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Enable pythonPath deprecation experiment to 4% of users #12002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Kudos, SonarCloud Quality Gate passed!
|
Since this experiment has not yet started. Should we be using the new framework? |
It'll take a couple of weeks until we'd be able to turn it on with the new framework. I'd rather start with this one and leave it as the last experiment with our old framework. |
}, | ||
{ | ||
"name": "DeprecatePythonPath - control", | ||
"salt": "DeprecatePythonPath", | ||
"min": 100, | ||
"max": 100 | ||
"max": 96 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
min
should be 96
and max should be 100
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karrtikr Good catch
I'm posting this coming from #2125 because that issue is referenced from the announcing blog post. Complete removal of Although it is true that Settings are not generally transferable from user to user and from machine to machine, so there is little point in sharing them. In those cases that one would want to share them, one would certainly want to separate transferable from non-transferable settings. Note the OP's issue wasn't the existence of Apparently the underlying issue is the lack of means for separation of transferable from non-transferable settings. That separation is inadequately addressed by removal of Question: Why can we not keep Perhaps even the experiment's |
Opened up a new issue #12313 to answer your queries, and I recommend opening new issues for how removing this setting is breaking things for you. |
To enable experiment for #2125