Skip to content

Add support for log points #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Apr 17, 2018

Fixes #1306
WIP - Need to add tests

This pull request:

@DonJayamanne DonJayamanne changed the title WIP - Add support for log points Add support for log points Apr 17, 2018
@codecov
Copy link

codecov bot commented Apr 17, 2018

Codecov Report

Merging #1406 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1406      +/-   ##
==========================================
+ Coverage   70.82%   70.91%   +0.08%     
==========================================
  Files         271      271              
  Lines       12488    12470      -18     
  Branches     2213     2207       -6     
==========================================
- Hits         8845     8843       -2     
+ Misses       3501     3486      -15     
+ Partials      142      141       -1
Impacted Files Coverage Δ
src/client/debugger/mainV2.ts 76.92% <100%> (-0.81%) ⬇️
src/client/common/configSettings.ts 88.16% <0%> (ø) ⬆️
src/client/common/types.ts 100% <0%> (ø) ⬆️
src/client/providers/jediProxy.ts 71.36% <0%> (+0.09%) ⬆️
...rc/client/debugger/PythonProcessCallbackHandler.ts 53.61% <0%> (+0.65%) ⬆️
src/client/providers/signatureProvider.ts 88.67% <0%> (+2.96%) ⬆️
src/client/activation/downloader.ts 24% <0%> (+3.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b38cb...e0697e9. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 41ec24a into microsoft:master Apr 17, 2018
@DonJayamanne DonJayamanne deleted the issue1306LogPoints branch June 20, 2018 03:14
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for 'LogPoints' in debugger
2 participants