Skip to content

Add workaround for truncated mypy output #13381 #15978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add workaround for truncated mypy output #13381 #15978

wants to merge 2 commits into from

Conversation

n4nn31355
Copy link

Workaround for: #13381

@kimadeline
Copy link

Hi @n4nn31355, thank you for your contribution!

Could you elaborate a bit on the purpose of this workaround? If you could also add a news file thanking yourself that would be great!

@ghost
Copy link

ghost commented May 3, 2021

CLA assistant check
All CLA requirements met.

@n4nn31355
Copy link
Author

n4nn31355 commented May 3, 2021

@kimadeline I added news file, hope its name is correct.
As for the purpose, I believe that whatever I can add to the info from the corresponding issue, is that it's pretty common to have pretty=True in setup.cfg or mypy config so you just call mypy ./src in CI and locally and always have consistent arguments

@kimadeline
Copy link

After discussing it with the team, we have chosen to not accept your PR for now, as we want to keep our list of defaults short, and let users configure the tools as they need, either by updating the setting globally, or using configuration files for the tools directly.

@kimadeline kimadeline closed this May 4, 2021
@GhostLyrics
Copy link

GhostLyrics commented Jul 2, 2021

@kimadeline In short: if you have enable pretty for mypy to show something fancy on the CLI, all strings will be cutoff and output inside of VSCode is useless. Examples attached.

image with pretty disabled via flags in VSCode

Screenshot 2021-07-02 at 23 26 02

image with pretty inherited from CLI config

Screenshot 2021-07-02 at 23 26 22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants