Fix issue with sys.prefix when getting environment details. #16386

karthiknadig · 2021-06-03T20:20:07Z

karrtikr

LGTM as a temp fix.

src/client/pythonEnvironments/info/environmentInfoService.ts

karrtikr · 2022-02-10T13:12:46Z

src/client/pythonEnvironments/legacyIOC.ts

+        const env = (await this.api.resolveEnv(envInfo)) ?? envInfo;
+        if (env.executable.sysPrefix) {
+            const execInfoService = getEnvironmentInfoService();
+            const info = await execInfoService.getEnvironmentInfo(pythonPath, EnvironmentInfoServiceQueuePriority.High);
+            if (info) {
+                env.executable.sysPrefix = info.executable.sysPrefix;
+                env.version = info.version;


@karthiknadig I don't think #16355 (comment) holds true anymore as we do not return from cache if it does not have complete info:

vscode-python/src/client/pythonEnvironments/base/locators/composite/envsCollectionCache.ts

Lines 129 to 137 in 2c47063

public getCompleteInfo(path: string): PythonEnvInfo | undefined {

// `path` can either be path to environment or executable path

let env = this.envs.find((e) => arePathsSame(e.location, path));

if (env?.hasCompleteInfo) {

return env;

}

env = this.envs.find((e) => areSameEnv(e, path));

return env?.hasCompleteInfo ? env : undefined;

}

So I'm going to remove this, please correct me if I'm wrong.

Fix issue with sys.prefix when getting environment details.

2b8fe64

github-actions bot assigned karthiknadig Jun 3, 2021

karthiknadig marked this pull request as ready for review June 4, 2021 17:41

github-actions bot requested review from kimadeline and paulacamargo25 June 4, 2021 17:42

karthiknadig requested a review from karrtikr June 4, 2021 18:17

karrtikr approved these changes Jun 4, 2021

View reviewed changes

src/client/pythonEnvironments/info/environmentInfoService.ts Outdated Show resolved Hide resolved

Fix typo

81585a1

kimadeline approved these changes Jun 4, 2021

View reviewed changes

Fix typo again

c9b54fa

karthiknadig merged commit 547243f into microsoft:main Jun 5, 2021

karthiknadig deleted the sysprefix branch June 8, 2021 15:40

karrtikr reviewed Feb 10, 2022

View reviewed changes

karrtikr mentioned this pull request May 18, 2022

Remove sys.prefix workaround which is no longer needed but still validate envs #19164

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix issue with sys.prefix when getting environment details. #16386

Fix issue with sys.prefix when getting environment details. #16386

Uh oh!

karthiknadig commented Jun 3, 2021

Uh oh!

karrtikr left a comment

Uh oh!

Uh oh!

karrtikr Feb 10, 2022

Uh oh!

Uh oh!

	public getCompleteInfo(path: string): PythonEnvInfo \| undefined {
	// `path` can either be path to environment or executable path
	let env = this.envs.find((e) => arePathsSame(e.location, path));
	if (env?.hasCompleteInfo) {
	return env;
	}
	env = this.envs.find((e) => areSameEnv(e, path));
	return env?.hasCompleteInfo ? env : undefined;
	}

Fix issue with sys.prefix when getting environment details. #16386

Fix issue with sys.prefix when getting environment details. #16386

Uh oh!

Conversation

karthiknadig commented Jun 3, 2021

Uh oh!

karrtikr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

karrtikr Feb 10, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!