Creating new Integrated Terminal doesn't take selected workspace into account when activating environment #17595
Conversation
src/client/terminals/activation.ts
Outdated
| @@ -9,6 +9,7 @@ import { IActiveResourceService, ITerminalManager } from '../common/application/ | |||
| import { ITerminalActivator } from '../common/terminal/types'; | |||
| import { IDisposable, IDisposableRegistry } from '../common/types'; | |||
| import { ITerminalAutoActivation } from './types'; | |||
| import { URI } from 'vscode-uri'; | |||
There was a problem hiding this comment.
You should add Uri to line 7. We don't need this package.
import { Terminal, Uri } from 'vscode';
|
Thank you for helping me through this. One test fails, is there a way to use the |
src/client/terminals/activation.ts
Outdated
| await this.activator.activateEnvironmentInTerminal(terminal, { | ||
| resource: this.activeResourceService.getActiveResource(), | ||
| resource: resource, |
There was a problem hiding this comment.
| resource: resource, | |
| resource, |
That is what it means by property short hand.
There was a problem hiding this comment.
If you install prettier extension, and set that as the formatter for TS. it should automatically do this for you.
There was a problem hiding this comment.
Yes, I'll fix this in a couple of hours from now! Thank you
|
I've formatted the file using Prettier in VSCode and then committed here. Although the details mention to run prettier, is the Tab count making a difference? I use the default number of spaces (8) for tab count as of now. |
|
@Vidushi-Gupta use 4 as the number of spaces. If that doesn't work I can fix this on my end. |
|
I changed the number of spaces and then formatted it on Prettier, but the test still fails. Is there anything else that I might be missing? |
used 4 tab spaces in prettier
… account when activating environment (microsoft#17595) * Worked on issue microsoft#15522 * worked on microsoft#15522 issue * added microsoft#15522 issue fix and contributor name * Impored Uri from VSCode * imported Uri correctly * imported Uri correctly * used short hand property on line 61 * formatted document using prettier * formatted code using prettier * formatted code using prettier * updated formatting of the document used 4 tab spaces in prettier * Fix formatting. Co-authored-by: Karthik Nadig <[email protected]>
… account when activating environment (#17595) * Worked on issue #15522 * worked on #15522 issue * added #15522 issue fix and contributor name * Impored Uri from VSCode * imported Uri correctly * imported Uri correctly * used short hand property on line 61 * formatted document using prettier * formatted code using prettier * formatted code using prettier * updated formatting of the document used 4 tab spaces in prettier * Fix formatting. Co-authored-by: Karthik Nadig <[email protected]>
… account when activating environment (microsoft/vscode-python#17595) * Worked on issue microsoft/vscode-python#15522 * worked on microsoft/vscode-python#15522 issue * added microsoft/vscode-python#15522 issue fix and contributor name * Impored Uri from VSCode * imported Uri correctly * imported Uri correctly * used short hand property on line 61 * formatted document using prettier * formatted code using prettier * formatted code using prettier * updated formatting of the document used 4 tab spaces in prettier * Fix formatting. Co-authored-by: Karthik Nadig <[email protected]>
Please let me know if there are any changes that I would have to make to this. Looking forward to contributing to Open Source!