Skip to content

Enable code refactoring when using the new Analysis Engine #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

DonJayamanne
Copy link

Fixes #1774

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)

@DonJayamanne
Copy link
Author

@MikhailArkhipov @brettcannon
Ideally we should be including this into the current release.

@codecov
Copy link

codecov bot commented May 31, 2018

Codecov Report

Merging #1801 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1801      +/-   ##
=========================================
- Coverage    74.1%     74%   -0.11%     
=========================================
  Files         282     282              
  Lines       13089   13090       +1     
  Branches     2335    2335              
=========================================
- Hits         9700    9687      -13     
- Misses       3259    3265       +6     
- Partials      130     138       +8
Impacted Files Coverage Δ
src/client/extension.ts 97.05% <100%> (+0.08%) ⬆️
src/client/activation/classic.ts 91.3% <100%> (-0.54%) ⬇️
src/client/debugger/PythonProcess.ts 45.83% <0%> (-5.42%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 53.61% <0%> (-0.66%) ⬇️
src/client/debugger/Main.ts 51.85% <0%> (-0.5%) ⬇️
src/client/debugger/mainV2.ts 80.72% <0%> (+0.8%) ⬆️
src/client/linters/lintingEngine.ts 91.15% <0%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d5f760...0044ab3. Read the comment docs.

@MikhailArkhipov
Copy link

@DonJayamanne - yes please, this should be in May.

@DonJayamanne DonJayamanne merged commit d112ab8 into microsoft:master Jun 1, 2018
@DonJayamanne DonJayamanne deleted the issue1774 branch June 20, 2018 03:13
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analysis engine breaks method and variable extraction
2 participants