Migrate over to using enabledApiProposals in package.json
#18269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrtikr
added
no-changelog
karrtikr
commented
Jan 11, 2022
Comment on lines
-1102
to
-1108
| export const IVSCodeNotebook = Symbol('IVSCodeNotebook'); | ||
| export interface IVSCodeNotebook { | ||
| readonly notebookDocuments: ReadonlyArray<NotebookDocument>; | ||
| readonly onDidOpenNotebookDocument: Event<NotebookDocument>; | ||
| readonly onDidCloseNotebookDocument: Event<NotebookDocument>; | ||
| createConcatTextDocument(notebook: NotebookDocument, selector?: DocumentSelector): NotebookConcatTextDocument; | ||
| } |
Comment on lines
-1
to
-19
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| import { inject, injectable } from 'inversify'; | ||
| import { DocumentSelector, Event, EventEmitter, workspace } from 'vscode'; | ||
| import type { notebook, NotebookConcatTextDocument, NotebookDocument } from 'vscode-proposed'; | ||
| import { UseProposedApi } from '../constants'; | ||
| import { IApplicationEnvironment, IVSCodeNotebook } from './types'; | ||
|
|
||
| @injectable() | ||
| export class VSCodeNotebook implements IVSCodeNotebook { | ||
| public get onDidOpenNotebookDocument(): Event<NotebookDocument> { | ||
| const onDidOpenNotebookDocument = | ||
| this.notebook.onDidOpenNotebookDocument ?? (workspace as any).onDidOpenNotebookDocument; | ||
| return this.canUseNotebookApi ? onDidOpenNotebookDocument : new EventEmitter<NotebookDocument>().event; | ||
| } | ||
| public get onDidCloseNotebookDocument(): Event<NotebookDocument> { | ||
| const onDidCloseNotebookDocument = | ||
| this.notebook.onDidCloseNotebookDocument ?? (workspace as any).onDidCloseNotebookDocument; |
|
I'm merging this PR but do let me know if there's an issue! |
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…oft/vscode-python#18269) * Migrate over to using `enabledApiProposals` in `package.json` * Update webpack build for browser * Upgrade vscode engine * Remove unused notebook class * Remove unnecessary proposed API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18184