-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add step to create Python file and modify svg for interpreter selection #18289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add step to create Python file and modify svg for interpreter selection #18289
Conversation
JFYI @misolori -- I edited (and potentially butchered) one of the SVGs but that's just temporarily 😅 we are going to try out moving the status bar item to the right in an experiment (more info here: #18283), so I figured it was worth hiding the status bar from the interpreter selection SVG in the mean time to not confuse users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a screenshot of what the new SVG looks like?
package.json
Outdated
"altText": "Selecting a python interpreter from the status bar" | ||
}, | ||
"when": "" | ||
}, | ||
{ | ||
"id": "python.runAndDebug", | ||
"title": "Run and debug your Python file", | ||
"description": "[Open](command:toSide:workbench.action.files.openFile) or [create](command:toSide:welcome.showNewFileEntries) a Python file - make sure to save it as \".py\". \n Click on the play button on the top right of the editor, or press F5 when on the file and select \"Python File\" to run with the debugger. \n \n[Learn more](https://code.visualstudio.com/docs/python/python-tutorial#_run-hello-world)", | ||
"description": "If you haven't already, [open](command:toSide:workbench.action.files.openFile) or [create](command:toSide:welcome.showNewFileEntries) a Python file - make sure to save it as \".py\". \n Click on the play button on the top right of the editor, or press F5 when on the file and select \"Python File\" to run with the debugger. \n \n[Learn more](https://code.visualstudio.com/docs/python/python-tutorial#_run-hello-world)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this change adds anything to the step. If you want to keep it, I would suggest the following:
"description": "If you haven't already, [open](command:toSide:workbench.action.files.openFile) or [create](command:toSide:welcome.showNewFileEntries) a Python file - make sure to save it as \".py\". \n Click on the play button on the top right of the editor, or press F5 when on the file and select \"Python File\" to run with the debugger. \n \n[Learn more](https://code.visualstudio.com/docs/python/python-tutorial#_run-hello-world)", | |
"description": "If you haven't done so already, [open](command:toSide:workbench.action.files.openFile) or [create](command:toSide:welcome.showNewFileEntries) a Python file - make sure to save it as \".py\". \n Click on the play button on the top right of the editor, or press F5 when on the file and select \"Python File\" to run with the debugger. \n \n[Learn more](https://code.visualstudio.com/docs/python/python-tutorial#_run-hello-world)", |
Co-authored-by: Kim-Adeline Miguel <[email protected]>
@kimadeline thank you so much for the review! I agree with you regarding the "if you haven't done so" bit -- it was unnecessary so I just removed it 😁 |
Co-authored-by: Kartik Raj <[email protected]>
…luabud/vscode-python into createpythonfilestepwalkthrough
…ions from run and debug tile
Thanks for the review and feedback @karrtikr! I added a tip to include the select interpreter command, and removed the "open or create" actions/links from the "run and debug" tile, so now they are just in the "create file" step. I ended up not using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Kartik Raj <[email protected]>
…on (microsoft/vscode-python#18289) * Add step to create Python file and modify svg for interpreter selection (temporarily) * Apply suggestions from code review Co-authored-by: Kim-Adeline Miguel <[email protected]> * Remove unnecessary wording * Remove unnecessary wording * Apply suggestions from code review Co-authored-by: Kartik Raj <[email protected]> * Add select interpreter command tip and remove open or create instructions from run and debug tile * Fix typo Co-authored-by: Kartik Raj <[email protected]> * Run prettier Co-authored-by: Kim-Adeline Miguel <[email protected]> Co-authored-by: Kartik Raj <[email protected]>
Closes #18287
The svg modification is just temporarily until we decide where we will end up placing the Python info on the status bar