Add step to create Python file and modify svg for interpreter selection #18289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luabud
added
no-changelog
luabud
requested review from
karrtikr,
kimadeline,
brettcannon and
karthiknadig
|
JFYI @misolori -- I edited (and potentially butchered) one of the SVGs but that's just temporarily 😅 we are going to try out moving the status bar item to the right in an experiment (more info here: #18283), so I figured it was worth hiding the status bar from the interpreter selection SVG in the mean time to not confuse users. |
kimadeline
reviewed
Jan 13, 2022
package.json
Outdated
| "altText": "Selecting a python interpreter from the status bar" | ||
| }, | ||
| "when": "" | ||
| }, | ||
| { | ||
| "id": "python.runAndDebug", | ||
| "title": "Run and debug your Python file", | ||
| "description": "[Open](command:toSide:workbench.action.files.openFile) or [create](command:toSide:welcome.showNewFileEntries) a Python file - make sure to save it as \".py\". \n Click on the play button on the top right of the editor, or press F5 when on the file and select \"Python File\" to run with the debugger. \n \n[Learn more](https://code.visualstudio.com/docs/python/python-tutorial#_run-hello-world)", | ||
| "description": "If you haven't already, [open](command:toSide:workbench.action.files.openFile) or [create](command:toSide:welcome.showNewFileEntries) a Python file - make sure to save it as \".py\". \n Click on the play button on the top right of the editor, or press F5 when on the file and select \"Python File\" to run with the debugger. \n \n[Learn more](https://code.visualstudio.com/docs/python/python-tutorial#_run-hello-world)", |
There was a problem hiding this comment.
I don't think this change adds anything to the step. If you want to keep it, I would suggest the following:
Suggested change
| "description": "If you haven't already, [open](command:toSide:workbench.action.files.openFile) or [create](command:toSide:welcome.showNewFileEntries) a Python file - make sure to save it as \".py\". \n Click on the play button on the top right of the editor, or press F5 when on the file and select \"Python File\" to run with the debugger. \n \n[Learn more](https://code.visualstudio.com/docs/python/python-tutorial#_run-hello-world)", | |
| "description": "If you haven't done so already, [open](command:toSide:workbench.action.files.openFile) or [create](command:toSide:welcome.showNewFileEntries) a Python file - make sure to save it as \".py\". \n Click on the play button on the top right of the editor, or press F5 when on the file and select \"Python File\" to run with the debugger. \n \n[Learn more](https://code.visualstudio.com/docs/python/python-tutorial#_run-hello-world)", |
ScreenshotsLight theme: Dark theme: High contrast theme: |
kimadeline
approved these changes
Jan 14, 2022
Co-authored-by: Kim-Adeline Miguel <[email protected]>
|
@kimadeline thank you so much for the review! I agree with you regarding the "if you haven't done so" bit -- it was unnecessary so I just removed it 😁 |
karthiknadig
approved these changes
Jan 14, 2022
karrtikr
reviewed
Jan 14, 2022
brettcannon
approved these changes
Jan 14, 2022
Co-authored-by: Kartik Raj <[email protected]>
…luabud/vscode-python into createpythonfilestepwalkthrough
…ions from run and debug tile
|
Thanks for the review and feedback @karrtikr! I added a tip to include the select interpreter command, and removed the "open or create" actions/links from the "run and debug" tile, so now they are just in the "create file" step. I ended up not using the |
|
|
Co-authored-by: Kartik Raj <[email protected]>
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…on (microsoft/vscode-python#18289) * Add step to create Python file and modify svg for interpreter selection (temporarily) * Apply suggestions from code review Co-authored-by: Kim-Adeline Miguel <[email protected]> * Remove unnecessary wording * Remove unnecessary wording * Apply suggestions from code review Co-authored-by: Kartik Raj <[email protected]> * Add select interpreter command tip and remove open or create instructions from run and debug tile * Fix typo Co-authored-by: Kartik Raj <[email protected]> * Run prettier Co-authored-by: Kim-Adeline Miguel <[email protected]> Co-authored-by: Kartik Raj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18287
The svg modification is just temporarily until we decide where we will end up placing the Python info on the status bar