Skip to content

Add step to create Python file and modify svg for interpreter selection #18289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 19, 2022

Conversation

luabud
Copy link
Member

@luabud luabud commented Jan 13, 2022

Closes #18287

The svg modification is just temporarily until we decide where we will end up placing the Python info on the status bar

@luabud luabud added no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating labels Jan 13, 2022
@luabud
Copy link
Member Author

luabud commented Jan 13, 2022

JFYI @misolori -- I edited (and potentially butchered) one of the SVGs but that's just temporarily 😅 we are going to try out moving the status bar item to the right in an experiment (more info here: #18283), so I figured it was worth hiding the status bar from the interpreter selection SVG in the mean time to not confuse users.

Copy link

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a screenshot of what the new SVG looks like?

package.json Outdated
"altText": "Selecting a python interpreter from the status bar"
},
"when": ""
},
{
"id": "python.runAndDebug",
"title": "Run and debug your Python file",
"description": "[Open](command:toSide:workbench.action.files.openFile) or [create](command:toSide:welcome.showNewFileEntries) a Python file - make sure to save it as \".py\". \n Click on the play button on the top right of the editor, or press F5 when on the file and select \"Python File\" to run with the debugger. \n \n[Learn more](https://code.visualstudio.com/docs/python/python-tutorial#_run-hello-world)",
"description": "If you haven't already, [open](command:toSide:workbench.action.files.openFile) or [create](command:toSide:welcome.showNewFileEntries) a Python file - make sure to save it as \".py\". \n Click on the play button on the top right of the editor, or press F5 when on the file and select \"Python File\" to run with the debugger. \n \n[Learn more](https://code.visualstudio.com/docs/python/python-tutorial#_run-hello-world)",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this change adds anything to the step. If you want to keep it, I would suggest the following:

Suggested change
"description": "If you haven't already, [open](command:toSide:workbench.action.files.openFile) or [create](command:toSide:welcome.showNewFileEntries) a Python file - make sure to save it as \".py\". \n Click on the play button on the top right of the editor, or press F5 when on the file and select \"Python File\" to run with the debugger. \n \n[Learn more](https://code.visualstudio.com/docs/python/python-tutorial#_run-hello-world)",
"description": "If you haven't done so already, [open](command:toSide:workbench.action.files.openFile) or [create](command:toSide:welcome.showNewFileEntries) a Python file - make sure to save it as \".py\". \n Click on the play button on the top right of the editor, or press F5 when on the file and select \"Python File\" to run with the debugger. \n \n[Learn more](https://code.visualstudio.com/docs/python/python-tutorial#_run-hello-world)",

@luabud
Copy link
Member Author

luabud commented Jan 14, 2022

Screenshots

Light theme:
image

Dark theme:
image

High contrast theme:
image

@luabud
Copy link
Member Author

luabud commented Jan 14, 2022

@kimadeline thank you so much for the review! I agree with you regarding the "if you haven't done so" bit -- it was unnecessary so I just removed it 😁

@luabud
Copy link
Member Author

luabud commented Jan 17, 2022

Thanks for the review and feedback @karrtikr! I added a tip to include the select interpreter command, and removed the "open or create" actions/links from the "run and debug" tile, so now they are just in the "create file" step. I ended up not using the pythonInterpreterInfoUnpinned context though, because I figured that could be "flickerish" situations where the tile would show up or disappear when the flight information is updated 🤔

@luabud
Copy link
Member Author

luabud commented Jan 17, 2022

image

image

image

image

image

Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

luabud and others added 2 commits January 18, 2022 09:18
Co-authored-by: Kartik Raj <[email protected]>
@luabud luabud merged commit 2c75b7d into microsoft:main Jan 19, 2022
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
…on (microsoft/vscode-python#18289)

* Add step to create Python file and modify svg for interpreter selection (temporarily)

* Apply suggestions from code review

Co-authored-by: Kim-Adeline Miguel <[email protected]>

* Remove unnecessary wording

* Remove unnecessary wording

* Apply suggestions from code review

Co-authored-by: Kartik Raj <[email protected]>

* Add select interpreter command tip and remove open or create instructions from run and debug tile

* Fix typo

Co-authored-by: Kartik Raj <[email protected]>

* Run prettier

Co-authored-by: Kim-Adeline Miguel <[email protected]>
Co-authored-by: Kartik Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update getting started experience related to Language status item experiments
5 participants