Skip to content

Conversation

@Harry-Hopkinson
Copy link

@Harry-Hopkinson Harry-Hopkinson commented Feb 16, 2022

Fix for #16840

Copy link

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Harry-Hopkinson,

Thank you for your contribution. Please do not make changes for 2 different issues in the same PR, and instead open 2 separate PRs.

Please also undo the change to the sprint-planning.github-issues file.

// Licensed under the MIT License.

// @ts-check
// eslint-disable-next-line @typescript-eslint/ban-ts-comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was for stopping type checking errors

@@ -0,0 +1 @@
Select the correct python path if no workspace path is available #18482

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The news entry is for #18529, but here you mention #18482. Please also see how news entries are usually written, and follow the same template.

@Harry-Hopkinson Harry-Hopkinson changed the title Select the correct python path if no workspace path is available #18482. Also removed unused dependencies from the package and package-lock.json #16840 Removed unused dependencies from the package and package-lock.json #16840 Feb 23, 2022
Copy link

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge main in your branch and resolve the merge conflicts, and undo the following changes:

  • vscode-debugadapter
  • vscode-debugadapter-testsupport
  • vscode-telemetry-extractor

Thanks!

"uuid": "^3.3.2",
"vsce": "^2.6.6",
"vscode-debugadapter-testsupport": "^1.27.0",
"vscode-telemetry-extractor": "^1.9.5",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vscode-telemetry-extractor is still in use.

"uint64be": "^1.0.1",
"unicode": "^10.0.0",
"untildify": "^3.0.2",
"vscode-debugadapter": "^1.28.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vscode-debugadapter, vscode-debugprotocol and vscode-debugadapter-testsupport are the 3 components of the debug adapter (repo), which the extension actively uses to provide debugger support.

"typescript-char": "^0.0.0",
"uint64be": "^1.0.1",
"unicode": "^10.0.0",
"untildify": "^3.0.2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untildify is still used by the extension.

@Harry-Hopkinson
Copy link
Author

I have merged the branches

"tmp": "^0.0.29",
"typescript-char": "^0.0.0",
"uint64be": "^1.0.1",
"unicode": "^10.0.0",
Copy link

@kimadeline kimadeline Mar 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is used during the webpack bundling process, please re-add it to package.json and re-generate the package-lock.json.

@kimadeline
Copy link

Hi there,

It seems like this PR ended in a stale state, despite the minimal changes. Please close this PR and open a new one with just the typescript-char and typescript-formatter changes + the news entry + the updated package-lock.json.

@kimadeline
Copy link

New PR at #18608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants