Skip to content

Using new vscode-engineering feature to abstract away gulp #19063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 3, 2022

Conversation

TylerLeonhardt
Copy link
Member

vscode-engineering will now run gulp for you. You just need to configure a few things to tell it where to look. The hope here is that we can simplify onboarding for extensions

@TylerLeonhardt
Copy link
Member Author

@paulacamargo25 I'm gonna merge this into your branch so that your branch is in a good state again.

@TylerLeonhardt TylerLeonhardt merged commit 7c9bcf7 into Add-localization May 3, 2022
@TylerLeonhardt TylerLeonhardt deleted the tyler/simpler-loc branch May 3, 2022 20:55
paulacamargo25 added a commit that referenced this pull request May 5, 2022
* Add localization (#18954)

* Enable localization using nls

* Add i18n files

* Add current translations

* Add export and import scripts

* Fix import translation function

* Clean code

* Update package-lock.json

* Delete i18n files

* Update package-lock.json

* Add news

* Fix package files

* Addd sourcemaps

* Add missing translations

* Remove localize test

* Add paths in pre-release

* Update pipeline

* Update pushStep

* Fix move item step

* Fix pull Steps

* Fix pipeline push and pull

* Fix translations import param

* Fix generate translations task

* Add generate translation task to compile script

* Add generate translations in the build steps

* Change i18n pt-br file name

* Delete package.nls.de.json

* Delete package.nls.pt-br.json

* Move generate translation task to PullStep

* Add nls webpack configuration

* Add nls config in extension.ts

* Try new path in webpack loader

* Test removing nls conf

* Add nls plugin

* Fix translations, remove nls pluging

* Remove unnecessary files

* Clean code

* Fix some comments

* Remove unnecessary packages

* Fix string with format

* Fix localize string

* Fix test in watcher

* Ignore localization files

* Change strings in tests

* Test importing nls in other file

* Fix comment in translations in tests

* Add missing translations

* Remove nls config in all files

* Add location steps in the stable pipeline

* Using new vscode-engineering feature to abstract away gulp (#19063)

* try new format

* remove nls gulp stuff

* back on main

* maybe use ../../

* try this

* try setting to where bundles are

* try new locBundleDestination

* try another

* try just src

* try

* try root dir

* Add i18n to vscodeignore

* Clean Code

* Remove old translations

* update templates to main

Co-authored-by: Tyler James Leonhardt <[email protected]>
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
* Add localization (microsoft/vscode-python#18954)

* Enable localization using nls

* Add i18n files

* Add current translations

* Add export and import scripts

* Fix import translation function

* Clean code

* Update package-lock.json

* Delete i18n files

* Update package-lock.json

* Add news

* Fix package files

* Addd sourcemaps

* Add missing translations

* Remove localize test

* Add paths in pre-release

* Update pipeline

* Update pushStep

* Fix move item step

* Fix pull Steps

* Fix pipeline push and pull

* Fix translations import param

* Fix generate translations task

* Add generate translation task to compile script

* Add generate translations in the build steps

* Change i18n pt-br file name

* Delete package.nls.de.json

* Delete package.nls.pt-br.json

* Move generate translation task to PullStep

* Add nls webpack configuration

* Add nls config in extension.ts

* Try new path in webpack loader

* Test removing nls conf

* Add nls plugin

* Fix translations, remove nls pluging

* Remove unnecessary files

* Clean code

* Fix some comments

* Remove unnecessary packages

* Fix string with format

* Fix localize string

* Fix test in watcher

* Ignore localization files

* Change strings in tests

* Test importing nls in other file

* Fix comment in translations in tests

* Add missing translations

* Remove nls config in all files

* Add location steps in the stable pipeline

* Using new vscode-engineering feature to abstract away gulp (microsoft/vscode-python#19063)

* try new format

* remove nls gulp stuff

* back on main

* maybe use ../../

* try this

* try setting to where bundles are

* try new locBundleDestination

* try another

* try just src

* try

* try root dir

* Add i18n to vscodeignore

* Clean Code

* Remove old translations

* update templates to main

Co-authored-by: Tyler James Leonhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants