Restart LS if python env info changes #19080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrtikr
reviewed
May 6, 2022
| const resource = Uri.parse(resourcePath); | ||
|
|
||
| // Restart the language server if the interpreter path changed (#18995). | ||
| if (info.envPath === interpreter?.envPath && info.path !== interpreter?.path) { |
There was a problem hiding this comment.
We should probably make sure info.envPath is not undefined or an empty string before restarting.
karthiknadig
pushed a commit
to karthiknadig/vscode-python
that referenced
this pull request
May 10, 2022
* Restart LS if python env info changes * Fix exit condition, add test case for no change
karthiknadig
pushed a commit
that referenced
this pull request
May 10, 2022
* Restart LS if python env info changes * Fix exit condition, add test case for no change
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
* Restart LS if python env info changes * Fix exit condition, add test case for no change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18995