Create environment using `venv` or `conda` #19848

karthiknadig · 2022-09-16T17:22:15Z

Closes #19676
Closes #19850

karthiknadig · 2022-09-21T00:38:18Z

src/client/common/utils/localize.ts

@@ -549,3 +549,82 @@ export namespace SwitchToDefaultLS {
        "The Microsoft Python Language Server has reached end of life. Your language server has been set to the default for Python in VS Code, Pylance.\n\nIf you'd like to change your language server, you can learn about how to do so [here](https://devblogs.microsoft.com/python/python-in-visual-studio-code-may-2021-release/#configuring-your-language-server).\n\nRead Pylance's license [here](https://marketplace.visualstudio.com/items/ms-python.vscode-pylance/license).",
    );
 }
+
+export namespace CreateEnv {


@luabud Strings here need your input.

karrtikr

Neatly done, most comments are similar related to wording.

Btw, are we not doing the "show log" hyperlink? @luabud

pythonFiles/create_conda.py

karrtikr · 2022-09-21T21:44:36Z

pythonFiles/create_venv.py

+
+def get_venv_path(name: str) -> str:
+    if sys.platform == "win32":
+        return os.fspath(CWD / name / "Scripts" / "python.exe")


Any documentation for this assumption?

This is the same assumption we have in the extension. The docs here describe the "Scripts" or "bin" : https://docs.python.org/3/library/venv.html#creating-virtual-environments

Gotcha.

Maybe still add a one line comment linking the doc? I'm asking because it looks like we actually don't use that assumption in discovery and identification:

vscode-python/src/client/pythonEnvironments/common/environmentManagers/simplevirtualenvs.ts

Lines 13 to 31 in e26a1ed

function getPyvenvConfigPathsFrom(interpreterPath: string): string[] {

const pyvenvConfigFile = 'pyvenv.cfg';

// Check if the pyvenv.cfg file is in the parent directory relative to the interpreter.

// env

// |__ pyvenv.cfg <--- check if this file exists

// |__ bin or Scripts

// |__ python <--- interpreterPath

const venvPath1 = path.join(path.dirname(path.dirname(interpreterPath)), pyvenvConfigFile);

// Check if the pyvenv.cfg file is in the directory as the interpreter.

// env

// |__ pyvenv.cfg <--- check if this file exists

// |__ python <--- interpreterPath

const venvPath2 = path.join(path.dirname(interpreterPath), pyvenvConfigFile);

// The paths are ordered in the most common to least common

return [venvPath1, venvPath2];

}

and this is the first time.

The purpose of the code here and in the discovery is different. In discovery we are tyring to find the .cfg file. in the create env, we created the env, so we know what type it is and where the python.exe will be. I can add the docs nonetheless.

Yes, I think the comment is misleading:

// envFolder // |__ pyvenv.cfg <--- check if this file exists // |__ python <--- interpreterPath

It seems to indicate python binary can be directly under the env folder.

src/client/common/utils/localize.ts

src/client/pythonEnvironments/creation/provider/condaCreationProvider.ts

src/client/pythonEnvironments/creation/types.ts

src/client/pythonEnvironments/creation/provider/condaCreationProvider.ts

pythonFiles/create_venv.py

karrtikr

Thanks for addressing, LGTM. I still think we could do the hyperlink to log channel #19848 (review) given it so nicely shows the command progress, otherwise looks good.

karthiknadig · 2022-09-23T21:55:50Z

I still think we could do the hyperlink to log channel

I will definitely add that in an update.

Closes microsoft#19676 Closes microsoft#19850

…9848) Closes microsoft/vscode-python#19676 Closes microsoft/vscode-python#19850

karthiknadig added the feature-request Request for new features or functionality label Sep 16, 2022

karthiknadig self-assigned this Sep 16, 2022

karthiknadig force-pushed the create_environment branch from 389156c to 303d763 Compare September 16, 2022 17:25

karthiknadig added the skip package*.json package.json and package-lock.json don't both need updating label Sep 16, 2022

karthiknadig added 26 commits September 20, 2022 17:31

Create environment provider.

b5cbdc8

Add classes supporting environment creation.

2e5ae43

Add general quickpick API.

4e4f60e

Implement venv support

48e31f8

Fix build.

d11fff5

Conda env creation support.

d323df9

Fix conda env creation.

703dc9e

Add status.

9f44ab6

Add detailed status.

cd09e93

Remove decoder.

b4c8d00

Improve localization

9fca478

Add tests for createEnvironment function.

71ab854

Add tests for create environment provider quick pick.

e9e7ca4

Clean-up localization on workspace selection.

7995c2c

More fixes and clean up.

1eb96cc

Fix localization quick pick.

952454c

Fix venv creation localization.

afc9c4f

Fix conda provider localization.

37fb908

Add workspace selection tests.

6b4cceb

Fix linting.

d7729ca

Fix typing.

69729f4

Use the new picker API.

29ba248

Add conda creation tests.

bc83068

Add venv tests.

7f6e503

Add conda tests

7463805

Fix build and localization.

e7b3516

Rebase with main.

7e38079

karthiknadig force-pushed the create_environment branch from 8fa2d0d to 7e38079 Compare September 21, 2022 00:36

karthiknadig requested a review from karrtikr September 21, 2022 00:37

karthiknadig commented Sep 21, 2022

View reviewed changes

karthiknadig marked this pull request as ready for review September 21, 2022 00:49

karthiknadig requested a review from eleanorjboyd September 21, 2022 00:51

eleanorjboyd previously approved these changes Sep 21, 2022

View reviewed changes

Remove unused libs.

861cd98

karthiknadig dismissed eleanorjboyd’s stale review via 861cd98 September 21, 2022 17:15

karrtikr reviewed Sep 21, 2022

View reviewed changes

src/client/pythonEnvironments/creation/provider/condaCreationProvider.ts Outdated Show resolved Hide resolved

Address comments.

c55d4c6

karthiknadig commented Sep 23, 2022

View reviewed changes

src/client/pythonEnvironments/creation/provider/condaCreationProvider.ts Show resolved Hide resolved

Add link to conda issue.

cbb337a

karthiknadig commented Sep 23, 2022

View reviewed changes

pythonFiles/create_venv.py Show resolved Hide resolved

Add doc link for venv binary location.

503c2da

karrtikr approved these changes Sep 23, 2022

View reviewed changes

karthiknadig mentioned this pull request Sep 23, 2022

Create Env: Add link to the log channel. #19879

Closed

karthiknadig merged commit 192c3ea into microsoft:main Sep 23, 2022

karthiknadig deleted the create_environment branch September 23, 2022 21:57

eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this pull request Oct 4, 2022

Create environment using venv or conda (microsoft#19848)

1dbc9c8

Closes microsoft#19676 Closes microsoft#19850

wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024

Create environment using venv or conda (microsoft/vscode-python#1…

50e3c9c

…9848) Closes microsoft/vscode-python#19676 Closes microsoft/vscode-python#19850

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Create environment using `venv` or `conda` #19848

Create environment using `venv` or `conda` #19848

Uh oh!

karthiknadig commented Sep 16, 2022 •

edited

Loading

Uh oh!

karthiknadig Sep 21, 2022

Uh oh!

karrtikr left a comment

Uh oh!

Uh oh!

Uh oh!

karrtikr Sep 21, 2022

Uh oh!

karthiknadig Sep 21, 2022

Uh oh!

karrtikr Sep 23, 2022

Uh oh!

karthiknadig Sep 23, 2022

Uh oh!

karrtikr Sep 23, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

karrtikr left a comment

Uh oh!

karthiknadig commented Sep 23, 2022

Uh oh!

Uh oh!

	function getPyvenvConfigPathsFrom(interpreterPath: string): string[] {
	const pyvenvConfigFile = 'pyvenv.cfg';

	// Check if the pyvenv.cfg file is in the parent directory relative to the interpreter.
	// env
	// \|__ pyvenv.cfg <--- check if this file exists
	// \|__ bin or Scripts
	// \|__ python <--- interpreterPath
	const venvPath1 = path.join(path.dirname(path.dirname(interpreterPath)), pyvenvConfigFile);

	// Check if the pyvenv.cfg file is in the directory as the interpreter.
	// env
	// \|__ pyvenv.cfg <--- check if this file exists
	// \|__ python <--- interpreterPath
	const venvPath2 = path.join(path.dirname(interpreterPath), pyvenvConfigFile);

	// The paths are ordered in the most common to least common
	return [venvPath1, venvPath2];
	}

Create environment using venv or conda #19848

Create environment using venv or conda #19848

Uh oh!

Conversation

karthiknadig commented Sep 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

karthiknadig Sep 21, 2022

Choose a reason for hiding this comment

Uh oh!

karrtikr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

karrtikr Sep 21, 2022

Choose a reason for hiding this comment

Uh oh!

karthiknadig Sep 21, 2022

Choose a reason for hiding this comment

Uh oh!

karrtikr Sep 23, 2022

Choose a reason for hiding this comment

Uh oh!

karthiknadig Sep 23, 2022

Choose a reason for hiding this comment

Uh oh!

karrtikr Sep 23, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

karrtikr left a comment

Choose a reason for hiding this comment

Uh oh!

karthiknadig commented Sep 23, 2022

Uh oh!

Uh oh!

Create environment using `venv` or `conda` #19848

Create environment using `venv` or `conda` #19848

karthiknadig commented Sep 16, 2022 •

edited

Loading