Skip to content

Add cancellation token support and link to logs. #19882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2022
Merged

Add cancellation token support and link to logs. #19882

merged 2 commits into from
Sep 26, 2022

Conversation

karthiknadig
Copy link
Member

Closes #19879

@karthiknadig karthiknadig self-assigned this Sep 26, 2022
@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Sep 26, 2022
@karthiknadig
Copy link
Member Author

karthiknadig commented Sep 26, 2022 •
edited
Loading

@cwebster-99 Do you think should say show logs or just logs is fine?
image

image

We can't add a button for this yet, in this progress notification.

@karthiknadig karthiknadig added the skip tests Updates to tests unnecessary label Sep 26, 2022
@karthiknadig karthiknadig removed the skip tests Updates to tests unnecessary label Sep 26, 2022
@cwebster-99
Copy link
Member

@cwebster-99 Do you think should say show logs or just logs is fine? image

image

We can't add a button for this yet, in this progress notification.

I prefer "show logs" as it is more descriptive of the user action.

cwebster-99
cwebster-99 approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@cwebster-99 cwebster-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like the "show logs" over "logs" in the prompt box.

@karthiknadig karthiknadig marked this pull request as ready for review September 26, 2022 19:35
@karthiknadig karthiknadig merged commit e23240e into microsoft:main Sep 26, 2022
@karthiknadig karthiknadig deleted the log_link branch September 27, 2022 19:06
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this pull request Oct 4, 2022
@karthiknadig @eleanorjboyd
Add cancellation token support and link to logs. (microsoft#19882)
ae9e272 
Closes microsoft#19879
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
@karthiknadig @wesm
Add cancellation token support and link to logs. (microsoft/vscode-py…
1d327e5 
…thon#19882)

Closes microsoft/vscode-python#19879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleanorjboyd eleanorjboyd eleanorjboyd approved these changes

@cwebster-99 cwebster-99 cwebster-99 approved these changes

Assignees

@karthiknadig karthiknadig

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Env: Add link to the log channel.
3 participants
@karthiknadig @cwebster-99 @eleanorjboyd