Auto activation of environment in new terminals #2277
Conversation
DonJayamanne
changed the title
brettcannon
changed the title
DonJayamanne
force-pushed
the
autoActivate
branch
from
e4979b0 to
2b8b8b3
Compare
DonJayamanne
force-pushed
the
autoActivate
branch
from
84ca8a1 to
c9e459c
Compare
DonJayamanne
changed the title
There was a problem hiding this comment.
I love that we are switching some of our test suites from system to unit tests! Let's do more of that when we can...
That being said, is there anything we can do, any event available we can hook into, to get rid of that sleep?
I've approved anyways because I realize this is a 'pre-existing condition', but if there is a way to get proper notification of when things are ready I'd love to get that made into an issue...
|
|
||
| // Give the command some time to complete. | ||
| // Its been observed that sending commands too early will strip some text off in VS Terminal. | ||
| const delay = (terminalShellType === TerminalShellType.powershell || TerminalShellType.powershellCore) ? 1000 : 500; |
There was a problem hiding this comment.
I would really love to see if we can get an event from the shell when it is 'ready' instead of this sleep stuff. Is there any issue related to this that VSCode knows about/can do anything about?
Do we know why this is the case at all?
There was a problem hiding this comment.
if we can get an event from the shell when it is 'ready' instead o
Not available.
Do we know why this is the case at all?
Powershell is slow. VS Code doesn't get any feedback when process in terminal has completed. Basically the stream is ready to write anytime.
There was a problem hiding this comment.
And we just use the VS Code api (which in turn doesn't provide any feedback on when stuff is ready or not, explained above).
There was a problem hiding this comment.
That being said, is there anything we can do, any event available we can hook into, to get rid of that sleep?
This has been an ongoing issue in VSC. Unfortunately nothing we can do at this stage.
| suite(testSuiteName, () => { | ||
| suite(testSuiteName, async function () { | ||
| // tslint:disable-next-line:no-invalid-this | ||
| this.timeout(5000); // Activation of terminals take some time (there's a delay in the code to account for VSC Terminal issues). |
There was a problem hiding this comment.
I mean, I know you have to up the limit here a bit in order to cope, but still, boo.
Fixes #1387
"1.2.3", not"^1.2.3")package-lock.jsonhas been regenerated if dependencies have changed