-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add typing_extensions
for backwards compatibility
#23180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@microsoft-github-policy-service agree |
|
||
from typing_extensions import Literal, TypedDict # noqa: E402 | ||
from testing_tools import socket_manager # noqa: E402 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suspect this import here may also have failed without the sys.path change?
@matthuisman Thanks for the PR. We need to discuss internally about supporting 3.7 as it is no longer in support upstream. |
was breaking 3.7 intentional? Be nice if there could be warning about it and some time for users to migrate etc |
@matthuisman We have announced this in our release notes and blogs:
We typically leave things as is until there is a change in underlying tools that we depend on. In this case, Python versions will drop on schedule and it is published here: https://devguide.python.org/versions/ |
typing_extensions
for backwards compatibility
Hey @matthuisman, first of all, thank you so much for being interested in contributing to our extension! However, based on the comments above, we'll close this PR. In our contributing guide we specify that we may reject a PR for issues that don't have the "needs PR" label, like the issue linked in this PR. I apologize for this frustration but I hope this doesn't discourage you from submitting more contributions! |
PySpark extensively uses Python 3.7 for example. |
PR: #22741 switched to importing TypedDict and Literal in two different files which has broken Python 3.7 (they added to typing in 3.8)
This PR reverts those changes back to using typing_extensions
related issue:
#23179