Ensure all messages are JSON rpc payloads #23362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
May 7, 2024
| @@ -24,7 +24,7 @@ fn get_env_path(path: &str) -> Option<String> { | |||
| fn report_path_python(dispatcher: &mut impl messaging::MessageDispatcher, path: &str) { | |||
| let version = utils::get_version(path); | |||
| let env_path = get_env_path(path); | |||
| dispatcher.send_message(messaging::PythonEnvironment::new( | |||
There was a problem hiding this comment.
The send_message is too generic.
Here we're sending PythonEnvironment directly, when instead we should be sending the PythonEnvironmentMessage
Added specific methods to avoid this issue (else the messages sent in the wire wasn't json rpc)
DonJayamanne
added
no-changelog
karthiknadig
approved these changes
May 7, 2024
|
I like this approach. |
anthonykim1
pushed a commit
to anthonykim1/vscode-python
that referenced
this pull request
May 16, 2024
DonJayamanne
added a commit
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.