Search for interpreters in all paths found in PATH variable #2575
Conversation
There was a problem hiding this comment.
Should be fine.
I do think about the potential for slowness though - for those developers who have a bunch of Python interpreters installed.
Do we want to add some telemetry on the time it takes to discover all the interpreters, to see if there is value in doing something more offloaded than this solution?
| searchPaths.push(path.join(pathUtils.home, p)); | ||
| }); | ||
| // Add support for paths such as /Users/xxx/anaconda/bin. | ||
| if (process.env.HOME) { |
There was a problem hiding this comment.
This is interesting. We know that Anaconda does something 'bespoke' and so we inject it into the search paths.
This is one of the reasons we might want to have the specific IInterpreter classes that you and I discussed the other day - you could simply query each known (registered) IInterpreter for getKnownSearchPaths or something like that.
Another one that comes to mind is pyenv, who's prescribed behaviour is to shove all the installed versions under $HOME/.pyenv...
There was a problem hiding this comment.
But its a chicken or the egg...
IInterpreter is the interpreter object that represents the interpreter info. Where do we get that object from. I.e. where do we get the python interpreter info from to begin with.
Fixes #2398
package.jsonare pinned (e.g."1.2.3", not"^1.2.3"for the specified version)package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)