[#2297] [WIP] Ensure that LS progress initialize is not duplicated. #2606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Should help with the 'infinite analyzing' issues we are seeing - May still have some work to do catching 'stateChange' messages
8 tasks
d3r3kk
commented
Sep 19, 2018
| // tslint:disable-next-line:no-suspicious-comment | ||
| // TODO: (from https://github.com/Microsoft/vscode-python/pull/2597#discussion_r217892043) | ||
| // For #2297 (while most of the problem is not here, restart is rare) you need | ||
| // to track 'stateChange' on the language client. When it gets to 'stopped' LS has terminated | ||
| } |
There was a problem hiding this comment.
@MikhailArkhipov is there something here I should do to improve things further?
I required this fix in my prior PR to get the behaviour I needed unfortunately.
I think it's best to close this PR unless I need to capture the 'stopped' state.
| @@ -29,7 +29,7 @@ export class ProgressReporting { | |||
| }); | |||
|
|
|||
| this.languageClient.onNotification('python/beginProgress', async _ => { | |||
| if (this.progressDeferred) { | |||
| if (this.progressDeferred) { // if we restarted, no worries as reporting will still funnel to the same place. | |||
There was a problem hiding this comment.
There's no change apart from adding a comment!
|
No need for this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2297
stateChangemessage and respond tostoppedstate indicatingthe LS has terminated.Any new/changed dependencies inpackage.jsonare pinned (e.g."1.2.3", not"^1.2.3"for the specified version)package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)