Skip to content

Fix issue 3561 - Spec.language may be null #3583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2018
Merged

Fix issue 3561 - Spec.language may be null #3583

merged 2 commits into from
Dec 7, 2018

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Dec 7, 2018

For #3561

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@rchiodo rchiodo self-assigned this Dec 7, 2018
DonJayamanne
DonJayamanne requested changes Dec 7, 2018
View reviewed changes
Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the title of the PR to reflect the change.

@rchiodo rchiodo changed the title Fix issue 3561 Fix issue 3561 - Spec.language may be null Dec 7, 2018
@rchiodo rchiodo merged commit a9e9c78 into master Dec 7, 2018
@rchiodo rchiodo deleted the rchiodo/fix_spec_language_issue branch December 11, 2018 00:41
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@IanMatthewHuff IanMatthewHuff Awaiting requested review from IanMatthewHuff

Assignees

@rchiodo rchiodo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rchiodo @DonJayamanne