Skip to content

Split out test-phases from PR validation into YAML step-template #4781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

d3r3kk
Copy link

@d3r3kk d3r3kk commented Mar 16, 2019

Preliminary PR, for #4034 and others.

  • Split out test phase 'steps' into a YAML step template.
    • This is to facilitate re-use across CI processes
  • Ensure all Python unit tests are running properly in PR/CI builds

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@d3r3kk d3r3kk added the no-changelog No news entry required label Mar 16, 2019
@codecov
Copy link

codecov bot commented Mar 16, 2019

Codecov Report

Merging #4781 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4781   +/-   ##
======================================
  Coverage      62%     62%           
======================================
  Files         373     373           
  Lines       14660   14660           
  Branches     1161    1161           
======================================
  Hits         9050    9050           
  Misses       5408    5408           
  Partials      202     202

@d3r3kk d3r3kk force-pushed the 4034_ci_runs_python_tests branch from de74fea to 705378c Compare March 18, 2019 18:09
@d3r3kk d3r3kk changed the title WIP: Run Python tests in CI Split out test-phases from PR validation into YAML step-template Mar 18, 2019
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

d3r3kk added 3 commits March 21, 2019 04:01
- will re-use the steps in CI and Nightly
- was running Python 3.7 in all cases before
- Updated AGENT_OS usage
- Add display name to show dependency versions (was 'Bash')
- skip Python unittests for normalizeForInterpreter in python 2.7
- run them before system tests in the interest of early exit for fast tests
- Do not run internal-tool tests on Python != 3.x
@d3r3kk d3r3kk force-pushed the 4034_ci_runs_python_tests branch from acb7bda to 5144d5f Compare March 21, 2019 11:05
@d3r3kk
Copy link
Author

d3r3kk commented Mar 21, 2019

This PR was covered in a subsequent PR that I've since merged!

@d3r3kk d3r3kk closed this Mar 21, 2019
@d3r3kk d3r3kk deleted the 4034_ci_runs_python_tests branch March 21, 2019 11:12
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants