Disable new debug adapter experiments #7996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
approved these changes
Oct 15, 2019
DonJayamanne
previously requested changes
Oct 15, 2019
karthiknadig
approved these changes
Oct 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #7996 +/- ##
=======================================
Coverage 58.95% 58.95%
=======================================
Files 499 499
Lines 22413 22413
Branches 3592 3592
=======================================
Hits 13213 13213
Misses 8371 8371
Partials 829 829Continue to review full report at Codecov.
|
…riment Co-Authored-By: Karthik Nadig <[email protected]>
karthiknadig
approved these changes
Oct 15, 2019
karthiknadig
dismissed
DonJayamanne’s stale review
Accepted suggested change.
karthiknadig
pushed a commit
to karthiknadig/vscode-python
that referenced
this pull request
Oct 16, 2019
* Disabling new debug adapter experiments * Apply suggestions from code review for turning off debug adapter experiment
karthiknadig
added a commit
to karthiknadig/vscode-python
that referenced
this pull request
Oct 21, 2019
This reverts commit 5c1d2bc.
karthiknadig
pushed a commit
to karthiknadig/vscode-python
that referenced
this pull request
Oct 21, 2019
* Disabling new debug adapter experiments * Apply suggestions from code review for turning off debug adapter experiment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has a news entry file (remember to thank yourself!)Appropriate comments and documentation strings in the codeHas sufficient logging.Has telemetry for enhancements.Unit tests & system/integration tests are added/updatedTest plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)The wiki is updated with any design decisions/details.