Skip to content

Disable new debug adapter experiments #7996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Oct 15, 2019
Merged

Conversation

luabud
Copy link
Member

@luabud luabud commented Oct 15, 2019

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [ ]Has a news entry file (remember to thank yourself!)
  • [ ]Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ]Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@luabud luabud added the no-changelog No news entry required label Oct 15, 2019
@codecov-io
Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Merging #7996 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7996   +/-   ##
=======================================
  Coverage   58.95%   58.95%           
=======================================
  Files         499      499           
  Lines       22413    22413           
  Branches     3592     3592           
=======================================
  Hits        13213    13213           
  Misses       8371     8371           
  Partials      829      829

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbabb6f...413b618. Read the comment docs.

@karthiknadig karthiknadig dismissed DonJayamanne’s stale review October 15, 2019 22:34

Accepted suggested change.

@karthiknadig karthiknadig merged commit 5c1d2bc into microsoft:master Oct 15, 2019
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this pull request Oct 16, 2019
* Disabling new debug adapter experiments
* Apply suggestions from code review for turning off debug adapter experiment
karthiknadig added a commit to karthiknadig/vscode-python that referenced this pull request Oct 21, 2019
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this pull request Oct 21, 2019
* Disabling new debug adapter experiments
* Apply suggestions from code review for turning off debug adapter experiment
@lock lock bot locked as resolved and limited conversation to collaborators Oct 22, 2019
@luabud luabud deleted the newchanges branch October 28, 2019 20:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants