Skip to content

Conversation

@DonJayamanne
Copy link

For #6907

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Oct 28, 2019
@DonJayamanne DonJayamanne requested a review from rchiodo October 28, 2019 20:59

// For a local connection we also need will append on the path to the ptvsd
// installed locally by the extension
// Actually until this is resolved: https://github.com/microsoft/vscode-python/issues/7615, skip adding
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove this comment here.

@codecov-io
Copy link

codecov-io commented Oct 28, 2019

Codecov Report

Merging #8258 into master will increase coverage by 0.3%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #8258     +/-   ##
=========================================
+ Coverage    58.7%   59.01%   +0.3%     
=========================================
  Files         504      504             
  Lines       23093    23101      +8     
  Branches     3728     3735      +7     
=========================================
+ Hits        13557    13632     +75     
+ Misses       8656     8589     -67     
  Partials      880      880
Impacted Files Coverage Δ
src/client/datascience/jupyter/jupyterDebugger.ts 10.73% <25%> (+0.67%) ⬆️
src/client/language/characters.ts 33.33% <0%> (+2.56%) ⬆️
src/client/common/utils/version.ts 81.48% <0%> (+3.7%) ⬆️
src/client/providers/providerUtilities.ts 88.88% <0%> (+5.55%) ⬆️
src/client/datascience/cellFactory.ts 89.65% <0%> (+13.79%) ⬆️
src/client/api.ts 92.85% <0%> (+14.28%) ⬆️
src/client/common/utils/icons.ts 100% <0%> (+16.66%) ⬆️
...cience/jupyter/jupyterDebuggerNotInstalledError.ts 80% <0%> (+20%) ⬆️
src/client/formatters/serviceRegistry.ts 100% <0%> (+25%) ⬆️
...ience/jupyter/jupyterDebuggerRemoteNotSupported.ts 100% <0%> (+25%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6046f83...a1bbabc. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 30862ad into microsoft:master Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 5, 2019
@DonJayamanne DonJayamanne deleted the issue6907 branch April 30, 2020 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants