Skip to content

Fix monaco editor style differences between insiders and shipping #8264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Oct 28, 2019

For #8006

Upgrade to latest monaco (latest on npm anyway)
Add style to make sure we match how monaco behaves in insiders
Checked that style is fine with shipping VS code too.

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-io
Copy link

codecov-io commented Oct 28, 2019

Codecov Report

Merging #8264 into master will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8264      +/-   ##
==========================================
+ Coverage    58.7%   59.02%   +0.31%     
==========================================
  Files         504      504              
  Lines       23093    23093              
  Branches     3728     3733       +5     
==========================================
+ Hits        13557    13630      +73     
+ Misses       8656     8583      -73     
  Partials      880      880
Impacted Files Coverage Δ
src/client/language/characters.ts 33.33% <0%> (+2.56%) ⬆️
src/client/common/utils/version.ts 81.48% <0%> (+3.7%) ⬆️
src/client/providers/providerUtilities.ts 88.88% <0%> (+5.55%) ⬆️
src/client/datascience/cellFactory.ts 89.65% <0%> (+13.79%) ⬆️
src/client/api.ts 92.85% <0%> (+14.28%) ⬆️
src/client/common/utils/icons.ts 100% <0%> (+16.66%) ⬆️
...cience/jupyter/jupyterDebuggerNotInstalledError.ts 80% <0%> (+20%) ⬆️
src/client/formatters/serviceRegistry.ts 100% <0%> (+25%) ⬆️
...ience/jupyter/jupyterDebuggerRemoteNotSupported.ts 100% <0%> (+25%) ⬆️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 100% <0%> (+33.33%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6046f83...1008957. Read the comment docs.

@rchiodo rchiodo merged commit 24dd883 into master Oct 28, 2019
@rchiodo rchiodo deleted the rchiodo/insiders_hover branch October 28, 2019 22:07
@lock lock bot locked as resolved and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants