Changing NewDebugAdapter experiment to be on for 50% of insiders users #8267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luabud
requested review from
brettcannon,
ericsnowcurrently,
karthiknadig and
kimadeline
Codecov Report
@@ Coverage Diff @@
## master #8267 +/- ##
=======================================
Coverage 59.32% 59.32%
=======================================
Files 504 504
Lines 23087 23087
Branches 3736 3736
=======================================
Hits 13697 13697
Misses 8498 8498
Partials 892 892
Continue to review full report at Codecov.
|
src/test/extension.unit.test.ts
Outdated
| @@ -23,31 +23,31 @@ suite('Extension API Debugger', () => { | |||
| const ptvsdPath = path.join('path', 'to', 'ptvsd'); | |||
|
|
|||
| let experimentsManager: IExperimentsManager; | |||
| let debugAdapterFactory: IDebugAdapterDescriptorFactory; | |||
| let debugAdapterFactoryInsiders: IDebugAdapterDescriptorFactory; | |||
There was a problem hiding this comment.
you don't need to change these. Revert changes in this file.
|
@ericsnowcurrently Since the experiment is new, users on stable version won't get anything, only insiders users will. Does that make sense? |
ericsnowcurrently
approved these changes
Oct 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8218
Has a news entry file (remember to thank yourself!)Appropriate comments and documentation strings in the codeHas sufficient logging.Has telemetry for enhancements.Test plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)The wiki is updated with any design decisions/details.