Minimize GPU usage for interactive and notebook editor #8268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidKutu
approved these changes
Oct 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #8268 +/- ##
=======================================
Coverage 59.02% 59.02%
=======================================
Files 504 504
Lines 23093 23093
Branches 3733 3733
=======================================
Hits 13630 13630
Misses 8583 8583
Partials 880 880
Continue to review full report at Codecov.
|
| @@ -54,13 +54,13 @@ function createTypeMoq<T>(tag: string): TypeMoq.IMock<T> { | |||
| } | |||
|
|
|||
| class MockStatusProvider implements IStatusProvider { | |||
| public set(_message: string, _timeout?: number, _cancel?: () => void, _panel?: IInteractiveBase): Disposable { | |||
| public set(_message: string, _inweb: boolean, _timeout?: number, _cancel?: () => void, _panel?: IInteractiveBase): Disposable { | |||
There was a problem hiding this comment.
I think I touched this too, so might have to merge on that review. Or visa versa. Assuming yours is in first.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8003, #8039
Fix the execution spinner to be back and minimize our GPU cost.
It should be noted that the majority of our cost is actually the spinner that VS code puts up.