Skip to content

Fix change directory command for native editor export #8269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

IanMatthewHuff
Copy link
Member

For #7567

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-io
Copy link

codecov-io commented Oct 28, 2019

Codecov Report

Merging #8269 into master will increase coverage by 0.07%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8269      +/-   ##
==========================================
+ Coverage   59.04%   59.11%   +0.07%     
==========================================
  Files         505      504       -1     
  Lines       23109    23152      +43     
  Branches     3736     3769      +33     
==========================================
+ Hits        13645    13687      +42     
+ Misses       8583     8576       -7     
- Partials      881      889       +8
Impacted Files Coverage Δ
src/client/datascience/types.ts 100% <ø> (ø) ⬆️
src/client/datascience/jupyter/jupyterImporter.ts 18.42% <0%> (ø) ⬆️
...ient/datascience/interactive-ipynb/nativeEditor.ts 58.19% <100%> (+4.34%) ⬆️
src/datascience-ui/react-common/constants.ts 0% <0%> (ø) ⬆️
src/client/datascience/statusProvider.ts
src/client/datascience/jupyter/jupyterDebugger.ts 10.11% <0%> (+0.05%) ⬆️
src/client/datascience/webViewHost.ts 48.18% <0%> (+0.9%) ⬆️
.../datascience/interactive-common/interactiveBase.ts 24.33% <0%> (+4.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77018a...9c3bffd. Read the comment docs.

@IanMatthewHuff IanMatthewHuff merged commit b5a9ca2 into microsoft:master Oct 29, 2019
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/fixNativeEditorDirChange branch October 29, 2019 18:22
@lock lock bot locked as resolved and limited conversation to collaborators Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants