Fix a number of issues related to opening new notebooks #8270
Conversation
Fix opening unsaved notebooks after extension update Fix creating new notebooks to be empty
Codecov Report
@@ Coverage Diff @@
## master #8270 +/- ##
==========================================
+ Coverage 59.29% 59.32% +0.03%
==========================================
Files 504 504
Lines 23071 23087 +16
Branches 3732 3736 +4
==========================================
+ Hits 13680 13697 +17
+ Misses 8502 8498 -4
- Partials 889 892 +3
Continue to review full report at Codecov.
|
|
|
||
| test('Opening file with local storage but no global will still open with old contents', async () => { | ||
| // This test is really for making sure when a user upgrades to a new extension, we still have their old storage | ||
| const file = Uri.parse('file://foo.ipynb'); |
There was a problem hiding this comment.
Take a peek at this in the debugger quick. I think the specification is incorrect here (though the test might pass). 'file://foo.ipynb' doesn't set the fsPath and puts the filename in the authority. 'file:///foo.ipynb' works.
There was a problem hiding this comment.
Yes you're right. The file name comes out as /. I'll change it and see if the tests still pass
There was a problem hiding this comment.
Sounds good, when you do that could you take a look at the other places that we do that in this file? Just so we don't get bit by this later? I should have already done that with my checkin when I noticed the issue, but I forgot to add them in.
In reply to: 340233792 [](ancestors = 340233792)
For #8132, #7980, #8263
Fixes for