Skip to content

Fix waitForMessage timeouts on the functional tests #8278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 29, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Oct 29, 2019

For #8255

Seems 3 seconds is not long enough to wait on the azure machines. Up'd to 65 seconds.

@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #8278 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8278      +/-   ##
==========================================
- Coverage   59.04%   58.96%   -0.08%     
==========================================
  Files         505      505              
  Lines       23109    23124      +15     
  Branches     3736     3741       +5     
==========================================
- Hits        13645    13636       -9     
- Misses       8583     8600      +17     
- Partials      881      888       +7
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 76.47% <0%> (-11.77%) ⬇️
src/client/common/platform/pathUtils.ts 66.66% <0%> (-5.56%) ⬇️
src/client/linters/pydocstyle.ts 84.61% <0%> (-5.13%) ⬇️
src/client/datascience/debugLocationTracker.ts 79.24% <0%> (-3.78%) ⬇️
src/client/interpreter/locators/helpers.ts 70.73% <0%> (-2.44%) ⬇️
src/client/common/process/proc.ts 13.28% <0%> (-1.57%) ⬇️
src/client/datascience/constants.ts 99.65% <0%> (-0.35%) ⬇️
src/datascience-ui/react-common/constants.ts 0% <0%> (ø) ⬆️
src/client/datascience/jupyter/jupyterDebugger.ts 10.73% <0%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77018a...9e48759. Read the comment docs.

@rchiodo rchiodo closed this Oct 29, 2019
@rchiodo rchiodo reopened this Oct 29, 2019
@rchiodo rchiodo merged commit 4531869 into master Oct 29, 2019
@rchiodo rchiodo deleted the rchiodo/wait_timeouts branch October 29, 2019 17:43
@lock lock bot locked as resolved and limited conversation to collaborators Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants