Skip to content

Fix gulp install python libs commands with python #8282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

kimadeline
Copy link

Fix installPtvsdWheels and installOldPtvsd commands when run on a machine that doesn't have an alias for python3.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@kimadeline kimadeline added the no-changelog No news entry required label Oct 29, 2019
@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #8282 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #8282      +/-   ##
=========================================
+ Coverage   59.01%   59.1%   +0.08%     
=========================================
  Files         505     505              
  Lines       23124   23154      +30     
  Branches     3741    3754      +13     
=========================================
+ Hits        13647   13685      +38     
+ Misses       8596    8579      -17     
- Partials      881     890       +9
Impacted Files Coverage Δ
src/client/datascience/jupyter/jupyterImporter.ts 13.2% <0%> (-5.22%) ⬇️
src/client/datascience/webViewHost.ts 48.18% <0%> (+0.9%) ⬆️
.../datascience/interactive-common/interactiveBase.ts 24.33% <0%> (+4.23%) ⬆️
...ient/datascience/interactive-ipynb/nativeEditor.ts 58.19% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4531869...453eaa5. Read the comment docs.

@kimadeline kimadeline merged commit 0d47bcc into microsoft:master Oct 29, 2019
@kimadeline kimadeline deleted the fix-gulpfile-install-python branch October 29, 2019 19:03
@lock lock bot locked as resolved and limited conversation to collaborators Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants