Skip to content

removed extra space at the left of the native editor #8288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2019

Conversation

DavidKutu
Copy link

For #8088

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@DavidKutu DavidKutu self-assigned this Oct 29, 2019
@DavidKutu DavidKutu added the no-changelog No news entry required label Oct 29, 2019
@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #8288 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8288   +/-   ##
=======================================
  Coverage   59.32%   59.32%           
=======================================
  Files         504      504           
  Lines       23087    23087           
  Branches     3736     3736           
=======================================
  Hits        13697    13697           
  Misses       8498     8498           
  Partials      892      892

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bcc7de...aa8faf7. Read the comment docs.

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Do we even need the 2px border?

  • We're adding borders and not displaying the border (it's transparent)
    Seems like a hack or something we forgot to remove.
    Why not use padding/margin when that's what we want!

@DavidKutu
Copy link
Author

It'll look the same, but ok.

@DavidKutu
Copy link
Author

The 2 px on the top is to separate cells a bit from the top line and to separate the cells themselves.
The 2 px on the right is to separate cells from the scrollbar.

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the 2px for top and right?

@DavidKutu DavidKutu merged commit abcea5a into master Oct 30, 2019
@DavidKutu DavidKutu deleted the davidkutu/remove_empty_space branch October 30, 2019 19:26
@lock lock bot locked as resolved and limited conversation to collaborators Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants