-
Notifications
You must be signed in to change notification settings - Fork 1.2k
removed extra space at the left of the native editor #8288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8288 +/- ##
=======================================
Coverage 59.32% 59.32%
=======================================
Files 504 504
Lines 23087 23087
Branches 3736 3736
=======================================
Hits 13697 13697
Misses 8498 8498
Partials 892 892 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Do we even need the 2px border?
-
We're adding borders and not displaying the border (it's transparent)
Seems like a hack or something we forgot to remove.
Why not use padding/margin when that's what we want!
It'll look the same, but ok. |
The 2 px on the top is to separate cells a bit from the top line and to separate the cells themselves. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the 2px
for top and right?
For #8088
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed)