Skip to content

Enhance "select a workspace" message when selecting interpreter #8299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2019

Conversation

kondratyev-nv
Copy link

For #8103

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #8299 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8299   +/-   ##
=======================================
  Coverage   59.33%   59.33%           
=======================================
  Files         504      504           
  Lines       23096    23096           
  Branches     3737     3737           
=======================================
  Hits        13704    13704           
  Misses       8500     8500           
  Partials      892      892
Impacted Files Coverage Δ
...t/interpreter/configuration/interpreterSelector.ts 65.57% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7418b74...7353518. Read the comment docs.

@kondratyev-nv
Copy link
Author

@kimadeline It looks like a trivial change, can we consider adding the skip news label?

@kimadeline
Copy link

kimadeline commented Oct 31, 2019

Hi @kondratyev-nv, since this PR refers to an existing issue please add a news file, even though it's an easy change. It helps us track changes and build the changelog.

Also, please merge master into your branch for the failing CI steps to pass.

Thank you for your contribution!

@kimadeline kimadeline self-requested a review October 31, 2019 16:08
@kimadeline kimadeline merged commit 788d9d9 into microsoft:master Oct 31, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 7, 2019
@kondratyev-nv kondratyev-nv deleted the issue_8103 branch August 6, 2021 11:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants