Skip to content

Prompt to open exported notebook in native editor #8315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 1, 2019
Merged

Prompt to open exported notebook in native editor #8315

merged 4 commits into from
Nov 1, 2019

Conversation

DonJayamanne
Copy link

For #8078

IanMatthewHuff
IanMatthewHuff approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-io
Copy link

codecov-io commented Oct 31, 2019 •
edited
Loading

Codecov Report

Merging #8315 into master will decrease coverage by <.01%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8315      +/-   ##
==========================================
- Coverage   59.24%   59.23%   -0.01%     
==========================================
  Files         508      508              
  Lines       23227    23236       +9     
  Branches     3746     3750       +4     
==========================================
+ Hits        13761    13765       +4     
- Misses       8573     8577       +4     
- Partials      893      894       +1
Impacted Files Coverage Δ
...ractive-window/interactiveWindowCommandListener.ts 59.61% <44.44%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 072ccea...c702d9d. Read the comment docs.

rchiodo
rchiodo approved these changes Oct 31, 2019
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne
Copy link
Author

Flaky CI

@DonJayamanne DonJayamanne reopened this Oct 31, 2019
@DonJayamanne DonJayamanne reopened this Oct 31, 2019
@DonJayamanne DonJayamanne reopened this Nov 1, 2019
@DonJayamanne DonJayamanne merged commit 7c6bede into microsoft:master Nov 1, 2019
@DonJayamanne DonJayamanne deleted the promptToExport branch November 1, 2019 20:18
@lock lock bot locked as resolved and limited conversation to collaborators Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@rchiodo rchiodo rchiodo approved these changes

@DavidKutu DavidKutu DavidKutu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DonJayamanne @codecov-io @IanMatthewHuff @rchiodo @DavidKutu @brettcannon