Adjust line number styles to line up with VSCode #8322
Conversation
| } | ||
| .monaco-editor .line-numbers { | ||
| color: var(--override-foreground, var(--vscode-editor-foreground)) !important; | ||
| } |
There was a problem hiding this comment.
What happens when you pick a weirdo theme? This might be using the base theme to pick the line number colors.
There was a problem hiding this comment.
Meaning the colors work fine for the base light and dark, but might not work for say One Plus or some other custom theme.
There was a problem hiding this comment.
I have installed and tested against around 20 different themes and it works as expected.
Please could you let me know which one doews'nt work.
RIght now, when I look at the webviews, VS Code is genearting these styles for us. So I don't see the need for us to generate them ourselves (hence the reason to remove them).
There was a problem hiding this comment.
No I didn't mean to say it wasn't working for me, just wanted to make sure you double check other themes.
There was a problem hiding this comment.
Double and triple checked.
Codecov Report
@@ Coverage Diff @@
## master #8322 +/- ##
==========================================
+ Coverage 58.66% 59.01% +0.35%
==========================================
Files 505 505
Lines 22778 23147 +369
Branches 3740 3740
==========================================
+ Hits 13363 13661 +298
- Misses 8522 8593 +71
Partials 893 893
Continue to review full report at Codecov.
|
| @@ -0,0 +1 @@ | |||
| Style adjustments to line numbers (color and width) in the `Native Editor`, to line up with VS Code styles. | |||
There was a problem hiding this comment.
line [](start = 79, length = 4)
Didn't @ronglums want lines on by default? Or is that another change?
For #8289