outputs will appear as a single textbox, with one scrollbar #8327
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8327 +/- ##
==========================================
+ Coverage 58.66% 59.22% +0.55%
==========================================
Files 505 508 +3
Lines 22778 23504 +726
Branches 3740 3821 +81
==========================================
+ Hits 13363 13920 +557
- Misses 8522 8657 +135
- Partials 893 927 +34
Continue to review full report at Codecov.
|
| @@ -345,59 +345,65 @@ export class CellOutput extends React.Component<ICellOutputProps> { | |||
|
|
|||
| // tslint:disable-next-line: max-func-body-length | |||
| private renderOutputs(outputs: nbformat.IOutput[]): JSX.Element[] { | |||
| return outputs.map(this.renderOutput); | |||
| // return outputs.map(this.renderOutput); | |||
There was a problem hiding this comment.
Go ahead and remove this old comment.
There was a problem hiding this comment.
Actually, this whole function seems a bit unneeded now? I guess we can keep it in for consistency of always returning an [] from the render* functions.
In reply to: 341634782 [](ancestors = 341634782)
There was a problem hiding this comment.
Yeah, the markdown render also returns an array.
There was a problem hiding this comment.
Sounds good. I'm fine to keep it then.
|
This change might've caused #8342 |
For #8049
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)