Skip to content

Add unit tests for common/process/pythonProcess.ts #8329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kimadeline
Copy link

For #6065 (needs to be merged before the conda work in #8259 where I will add more tests to pythonProcess.ts)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Oct 31, 2019

Codecov Report

Merging #8329 into master will increase coverage by 0.57%.
The diff coverage is 49.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8329      +/-   ##
==========================================
+ Coverage   58.66%   59.23%   +0.57%     
==========================================
  Files         505      508       +3     
  Lines       22778    23236     +458     
  Branches     3740     3750      +10     
==========================================
+ Hits        13363    13765     +402     
- Misses       8522     8577      +55     
- Partials      893      894       +1
Impacted Files Coverage Δ
src/client/datascience/serviceRegistry.ts 0% <0%> (ø)
...ractive-window/interactiveWindowCommandListener.ts 59.61% <44.44%> (-0.69%) ⬇️
src/client/datascience/jupyter/kernelService.ts 54.67% <54.67%> (ø)
src/client/datascience/jupyter/notebookStarter.ts 59.34% <59.34%> (ø)
src/client/datascience/jupyter/jupyterExecution.ts 51.03% <87.5%> (-1.34%) ⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 100% <0%> (ø) ⬆️
src/client/formatters/serviceRegistry.ts 100% <0%> (ø) ⬆️
...lient/datascience/jupyter/jupyterSelfCertsError.ts 100% <0%> (ø) ⬆️
src/client/debugger/extension/serviceRegistry.ts 100% <0%> (ø) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e713994...52684b8. Read the comment docs.

@kimadeline kimadeline marked this pull request as ready for review November 1, 2019 22:28
Copy link
Member

@karthiknadig karthiknadig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this check we are only testing one of the branches. Given string manipulation here I recommend adding a test for both the branches. This is non-blocking comment, i will leave it to up to you if this is needed.

const versionValue = json.versionInfo.length === 4 ? `${json.versionInfo.slice(0, 3).join('.')}-${json.versionInfo[3]}` : json.versionInfo.join('.');

@kimadeline kimadeline merged commit eeba4cb into microsoft:master Nov 4, 2019
@kimadeline kimadeline deleted the 6065-unit-tests-python-process branch November 4, 2019 17:23
@lock lock bot locked as resolved and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants