-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add unit tests for common/process/pythonProcess.ts #8329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for common/process/pythonProcess.ts #8329
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8329 +/- ##
==========================================
+ Coverage 58.66% 59.23% +0.57%
==========================================
Files 505 508 +3
Lines 22778 23236 +458
Branches 3740 3750 +10
==========================================
+ Hits 13363 13765 +402
- Misses 8522 8577 +55
- Partials 893 894 +1
Continue to review full report at Codecov.
|
…e/vscode-python into 6065-unit-tests-python-process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this check we are only testing one of the branches. Given string manipulation here I recommend adding a test for both the branches. This is non-blocking comment, i will leave it to up to you if this is needed.
const versionValue = json.versionInfo.length === 4 ? `${json.versionInfo.slice(0, 3).join('.')}-${json.versionInfo[3]}` : json.versionInfo.join('.'); |
For #6065 (needs to be merged before the conda work in #8259 where I will add more tests to
pythonProcess.ts
)package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed)