Skip to content

Gathered nb's from py don't show original file. #8374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Update data science walkthrough illustrations
merged 1 commit into from
Nov 5, 2019
Merged

Gathered nb's from py don't show original file. #8374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/client/datascience/gather/gatherListener.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { IConfigurationService } from '../../common/types';
import * as localize from '../../common/utils/localize';
import { noop } from '../../common/utils/misc';
import { generateCellsFromString } from '../cellFactory';
import { Identifiers } from '../constants';
import { IInteractiveWindowMapping, InteractiveWindowMessages } from '../interactive-common/interactiveWindowTypes';
import { ICell, IGatherExecution, IInteractiveWindowListener, IInteractiveWindowProvider, IJupyterExecution, INotebook, INotebookEditorProvider, INotebookExporter } from '../types';
import { GatherLogger } from './gatherLogger';
Expand Down Expand Up @@ -102,11 +103,11 @@ export class GatherListener implements IInteractiveWindowListener {
if (this.configService.getSettings().datascience.gatherToScript) {
await this.showFile(slicedProgram, cell.file);
} else {
await this.showNotebook(slicedProgram);
await this.showNotebook(slicedProgram, cell);
}
}

private async showNotebook(slicedProgram: string) {
private async showNotebook(slicedProgram: string, cell: ICell) {
if (slicedProgram) {
let cells: ICell[] = [{
id: uuid(),
Expand All @@ -115,7 +116,7 @@ export class GatherListener implements IInteractiveWindowListener {
state: 0,
data: {
cell_type: 'markdown',
source: localize.DataScience.gatheredNotebookDescriptionInMarkdown().format(this.notebookUri.fsPath),
source: localize.DataScience.gatheredNotebookDescriptionInMarkdown().format(cell.file === Identifiers.EmptyFileName ? this.notebookUri.fsPath : cell.file),
metadata: {}
}
}];
Expand Down