Correctly handle interpreter changes for Interactive and Notebook #8385
Conversation
| @@ -935,7 +935,9 @@ export abstract class InteractiveBase extends WebViewHost<IInteractiveWindowMapp | |||
|
|
|||
| private onInterpreterChanged = () => { | |||
| // Update our load promise. We need to restart the jupyter server | |||
| this.loadPromise = this.reloadWithNew(); | |||
| if (this.loadPromise) { | |||
There was a problem hiding this comment.
So this was the fix for the immediate server loading issue. But as it turns out, interpreter switching was just totally broken. It would look like it was loading, but just pick the same cached server even when you swapped interpreters.
| const isRollingBuild = process.env ? process.env.VSCODE_PYTHON_ROLLING !== undefined : false; | ||
|
|
||
| // Real Jupyter doesn't help this test at all and is tricky to set up for it, so just skip it | ||
| if (!isRollingBuild) { |
There was a problem hiding this comment.
If you think this is wrong I can look into it, but I don't think that real python actually buys us anything for this test, and I think that it would be difficult to set up. Particularly with lockdown tomorrow.
Codecov Report
@@ Coverage Diff @@
## master #8385 +/- ##
==========================================
+ Coverage 58.7% 59.37% +0.66%
==========================================
Files 509 509
Lines 22923 23299 +376
Branches 3754 3763 +9
==========================================
+ Hits 13457 13833 +376
+ Misses 8570 8567 -3
- Partials 896 899 +3
Continue to review full report at Codecov.
|
For #8019
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)