Skip to content

WIP 🐛 use map instead of filter to return a promise #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DonJayamanne
Copy link

Fix bug introduced in #831
Selection of interpreters throws error. Not creating an issue for this, just tying it to the original issue that #831 resolved.
Using map to ensure a promise is returned.

@DonJayamanne DonJayamanne changed the title 🐛 use map instead of filter to return a promise WIP 🐛 use map instead of filter to return a promise Feb 21, 2018
@DonJayamanne
Copy link
Author

Will add a test to test this.

@DonJayamanne DonJayamanne force-pushed the fixInterpreterSelection branch from d991830 to 459a1c5 Compare February 21, 2018 08:06
@DonJayamanne DonJayamanne force-pushed the fixInterpreterSelection branch from 459a1c5 to 7841c03 Compare February 21, 2018 08:07
@codecov
Copy link

codecov bot commented Feb 21, 2018

Codecov Report

Merging #842 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
- Coverage   63.46%   63.45%   -0.01%     
==========================================
  Files         258      258              
  Lines       11845    11843       -2     
  Branches     2104     2104              
==========================================
- Hits         7517     7515       -2     
  Misses       4320     4320              
  Partials        8        8
Impacted Files Coverage Δ
...t/interpreter/configuration/interpreterSelector.ts 46.51% <100%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e543b...7841c03. Read the comment docs.

@MikhailArkhipov MikhailArkhipov merged commit cd67eb0 into microsoft:master Feb 21, 2018
@DonJayamanne DonJayamanne deleted the fixInterpreterSelection branch February 22, 2018 19:21
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants