Skip to content

Bypass conda service when creating daemons #9454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2020
Merged

Bypass conda service when creating daemons #9454

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c274d73
Scrape output to get the details of the registered kernel
DonJayamanne Jan 8, 2020
e572be6
Bypass conda run for DS code
DonJayamanne Jan 8, 2020
bde5a0b
Oops
DonJayamanne Jan 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client/datascience/jupyter/notebookStarter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ export class NotebookStarter implements Disposable {
const isActiveInterpreter = activeInterpreter ? activeInterpreter.path === interpreter.path : false;
const daemon = await (isActiveInterpreter
? this.executionFactory.createDaemon({ daemonModule: PythonDaemonModule, pythonPath: interpreter.path })
: this.executionFactory.createActivatedEnvironment({ allowEnvironmentFetchExceptions: true, interpreter }));
: this.executionFactory.createActivatedEnvironment({ allowEnvironmentFetchExceptions: true, interpreter, bypassCondaExecution: true }));
// We have a small python file here that we will execute to get the server info from all running Jupyter instances
const newOptions: SpawnOptions = { mergeStdOutErr: true, token: cancelToken };
const file = path.join(EXTENSION_ROOT_DIR, 'pythonFiles', 'datascience', 'getServerInfo.py');
Expand Down