Skip to content

Disable conda execution service instantiation #9493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 10, 2020

Conversation

kimadeline
Copy link

For #9490

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #9493 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9493      +/-   ##
==========================================
- Coverage   60.88%   60.85%   -0.03%     
==========================================
  Files         530      530              
  Lines       28631    28638       +7     
  Branches     4340     4341       +1     
==========================================
- Hits        17433    17429       -4     
- Misses      10245    10253       +8     
- Partials      953      956       +3
Impacted Files Coverage Δ
...rc/client/common/process/pythonExecutionFactory.ts 97.53% <ø> (+0.82%) ⬆️
src/client/common/process/condaExecutionService.ts 70% <0%> (-30%) ⬇️
src/client/interpreter/activation/service.ts 84.93% <0%> (-2.77%) ⬇️
...lient/datascience/jupyter/kernels/kernelService.ts 54.92% <0%> (-1.17%) ⬇️
src/client/common/process/proc.ts 15.21% <0%> (-0.23%) ⬇️
...rc/client/common/application/webPanels/webPanel.ts 13.63% <0%> (ø) ⬆️
src/client/common/constants.ts 100% <0%> (ø) ⬆️
src/client/common/process/types.ts 100% <0%> (ø) ⬆️
src/client/common/process/pythonDaemonPool.ts 69.53% <0%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f234f...dc46b2d. Read the comment docs.

@kimadeline kimadeline marked this pull request as ready for review January 9, 2020 22:00
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kimadeline
Copy link
Author

@kimadeline kimadeline merged commit 99126ad into microsoft:master Jan 10, 2020
@kimadeline kimadeline deleted the 9490-conda-run-revert branch January 10, 2020 02:04
kimadeline added a commit to kimadeline/vscode-python that referenced this pull request Jan 10, 2020
* Disable conda execution service instantiation
* News file
* Didn't mean to commit that
* Forgot a few tests
* Linting
* Update comment
kimadeline added a commit that referenced this pull request Jan 10, 2020
* Revert calling mypy with relatives paths (regression) (#9502)
* Revert "fix(client/linters/mypy): call mypy incorrectly (#5834)"
This reverts commit 1b6fbfb.
* News file
* Revert "Fix MyPy CI tests (#8518)"
This reverts commit c634ffd.
* Disable conda execution service instantiation (#9493)
* Disable conda execution service instantiation
* News file
* Didn't mean to commit that
* Forgot a few tests
* Linting
* Update comment
* Linting
* Test failure caused by linting
* Undo tslint formatting change
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants