This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Extend removeRefCommand to support call hierarchy items #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Babak Khalkhali Shandiz <[email protected]>
Signed-off-by: Babak Khalkhali Shandiz <[email protected]>
Signed-off-by: Babak Khalkhali Shandiz <[email protected]>
Signed-off-by: Babak Khalkhali Shandiz <[email protected]>
Signed-off-by: Babak Khalkhali Shandiz <[email protected]>
|
|
|
@jrieken Is this PR going to be merged for this release? |
|
Sorry this got lost... Will look into it |
jrieken
suggested changes
Aug 11, 2020
Signed-off-by: Babak Khalkhali Shandiz <[email protected]>
Signed-off-by: Babak Khalkhali Shandiz <[email protected]>
Signed-off-by: Babak Khalkhali Shandiz <[email protected]>
Signed-off-by: Babak Khalkhali Shandiz <[email protected]>
jrieken
reviewed
Sep 1, 2020
jrieken
reviewed
Sep 1, 2020
src/extension.ts
Outdated
| @@ -254,6 +254,21 @@ export function activate(context: vscode.ExtensionContext) { | |||
| view.reveal(next, { select: true }); | |||
| } | |||
| } | |||
| else if (model instanceof CallsModel) { | |||
jrieken
reviewed
Sep 1, 2020
src/models.ts
Outdated
| async getCallChildren(call: CallItem): Promise<CallItem[]> { | ||
| if (call.children) | ||
| return call.children; | ||
| call.children = await this.resolveCalls(call); |
There was a problem hiding this comment.
Is resolveCalls now only used from this method? Should it be private async _resolveCalls... then or should they be merged into on?
There was a problem hiding this comment.
They can be merged into a single method, but that doesn't accommodate SRP. I've changed it to make resolveCalls a private method.
jrieken
reviewed
Sep 1, 2020
src/provider.ts
Outdated
| } | ||
|
|
||
| getParent(element: CallHierarchyItem) { | ||
| return element.parent; | ||
| return element ? element.parent : undefined; |
There was a problem hiding this comment.
why? element should never be falsy
There was a problem hiding this comment.
Sorry. I didn't notice the parameter's type.
Signed-off-by: Babak Khalkhali Shandiz <[email protected]>
Signed-off-by: Babak Khalkhali Shandiz <[email protected]>
Signed-off-by: Babak Khalkhali Shandiz <[email protected]>
Signed-off-by: Babak Khalkhali Shandiz <[email protected]>
Signed-off-by: Babak Khalkhali Shandiz <[email protected]>
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is following this issue on VS Code repo. In short, it was asked to also enable the "remove" button for call hierarchy trees to help users cancel out any items they've reviewed.
The problem with adding this feature was that the implementation of the call hierarchy tree, would resolve outgoing/incoming calls on demand (i.e., when the user clicked to expand a node) and then the children data were not taken hold of in the models.
To fulfill the request, a
childrenproperty was added to theCallItemmodel, andmove,removeand change events were added to theCallsModelclass. The originalremoveRefCommandof the extension was updated accordingly.ReferencesModel._del, it's been moved to the outer context and referenced from withinCallsModel, too. Also, to be consistent,ReferencesModel._tailwas moved with the former.