Skip to content

Auto port forwarding = false not respected when there's a tunnel provider #5208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexr00 opened this issue Jun 16, 2021 · 3 comments
Closed

Auto port forwarding = false not respected when there's a tunnel provider #5208

alexr00 opened this issue Jun 16, 2021 · 3 comments
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release remote-explorer verified Verification succeeded
Milestone
May 2021 Recovery

Comments

@alexr00
Copy link
Member

alexr00 commented Jun 16, 2021

There is a race that occurs when auto port forwarding is off but there is also a tunnel provider registered.

In this case, even though auto port forwarding is off we still watch the proc filesystem so that the process info in the ports view can be filled in. However, because of the race, auto port forwarding still occurs.
@alexr00 alexr00 self-assigned this Jun 16, 2021
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug remote-explorer labels Jun 16, 2021
@alexr00 alexr00 added this to the May 2021 Recovery milestone Jun 16, 2021
@alexr00 alexr00 added the candidate Issue identified as probable candidate for fixing in the next release label Jun 16, 2021
@alexr00
Copy link
Member Author

alexr00 commented Jun 16, 2021

Fixed in main by microsoft/vscode@41c86e5

This was referenced Jun 16, 2021
Closed
Merged
alexr00 added a commit to microsoft/vscode that referenced this issue Jun 16, 2021
@alexr00
Fix race that causes auto port forwarding setting to be ignored (#126481
08bca48 
)

* Fix race in proc based port finding

* Check port auto forward setting after waiting

Fixes microsoft/vscode-remote-release#5208
@alexr00 alexr00 closed this as completed Jun 16, 2021
@cmbrose
Copy link

cmbrose commented Jun 17, 2021

Verified that this fix works as expected in codespaces for the github/github repro

@alexr00 alexr00 added the verified Verification succeeded label Jun 17, 2021
@aloTu
Copy link

aloTu commented Jul 16, 2021

thanks！

@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release remote-explorer verified Verification succeeded
Projects
None yet
Milestone
May 2021 Recovery
Development

No branches or pull requests
3 participants
@cmbrose @alexr00 @aloTu